Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyiron table: Change default executor to "pympipool.mpi.executor.PyMPIExecutor" #1369

Merged
merged 3 commits into from
Mar 12, 2024
Merged

pyiron table: Change default executor to "pympipool.mpi.executor.PyMPIExecutor" #1369

merged 3 commits into from
Mar 12, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Mar 12, 2024 •
edited
Loading

Change the default executor from concurrent.futures.ProcessPoolExecutor to pympipool.mpi.executor.PyMPIExecutor as the ProcessPoolExecutor does not support lambda functions.

@jan-janssen jan-janssen linked an issue Mar 12, 2024 that may be closed by this pull request
Tables broken with default executor #1362
Closed
@jan-janssen jan-janssen requested a review from pmrv March 12, 2024 03:13
@pmrv
Copy link
Contributor

pmrv commented Mar 12, 2024

I've updated the create_table docstring to highlight the problem and point others to pympipool, but otherwise lgtm. Thanks for the fix.

pmrv
pmrv approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jan-janssen jan-janssen merged commit 4a40bd0 into main Mar 12, 2024
25 checks passed
@jan-janssen jan-janssen deleted the pyiron_table_default_executor branch March 12, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tables broken with default executor
2 participants
@jan-janssen @pmrv