Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Os - pympipool: Use localhost for connection rather than the network address #1390

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Mac Os - pympipool: Use localhost for connection rather than the network address #1390

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6586ba5
Mac Os - pympipool: Use localhost for connection rather than the netw…
jan-janssen Mar 19, 2024
b582f93
Format black
pyiron-runner Mar 19, 2024
aa52b6c
fix unnecessary restriction
jan-janssen Mar 19, 2024
0958283
Merge remote-tracking branch 'origin/mac_hostname' into mac_hostname
jan-janssen Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pyiron_base/jobs/job/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from datetime import datetime
from inspect import isclass
import os
import platform
import posixpath
import warnings

Expand Down Expand Up @@ -1534,6 +1535,14 @@ def _get_executor(self, max_workers=None):
raise ValueError(
"No executor type defined - Please set self.executor_type."
)
elif (
self._executor_type == "pympipool.mpi.executor.PyMPIExecutor"
and platform.system() == "Darwin"
):
# The Mac firewall might prevent connections based on the network address - especially Github CI
return import_class(self._executor_type)(
max_workers=max_workers, hostname_localhost=True
)
elif isinstance(self._executor_type, str):
return import_class(self._executor_type)(max_workers=max_workers)
else:
Expand Down
Loading