Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make normal nodes slow #648

Merged
merged 7 commits into from
May 1, 2023
Merged

Make normal nodes slow #648

merged 7 commits into from
May 1, 2023

Conversation

liamhuber
Copy link
Member

I.e. they should default runs_on_updates and updates_on_instantiation both to False.

All the documentation and examples are updated accordingly, and the library of nodes makes as many as possible SingleValueNodes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@liamhuber
Copy link
Member Author

This stacked PR updates the docstrings and example notebook, so I don't want to merge it's parent without it. Merging into parent now.

@liamhuber liamhuber merged commit 1b88517 into fast_nodes May 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the make_normal_nodes_slow branch May 1, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant