Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Remove node job #415

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[minor] Remove node job #415

merged 2 commits into from
Aug 8, 2024

Conversation

liamhuber
Copy link
Member

The entire module is moved over to pyiron_contrib: pyiron/pyiron_contrib#1126.

This allows us to remove both pyiron_base and h5io dependencies.

Copy link

github-actions bot commented Aug 8, 2024

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/remove_node_job

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ef5103b1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ef5103b) Report Missing Report Missing Report Missing
Head commit (c9e4aaa) 3341 3041 91.02%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#415) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@liamhuber liamhuber marked this pull request as ready for review August 8, 2024 22:01
@liamhuber liamhuber merged commit 8c7fc68 into only_pickle_storage Aug 8, 2024
16 checks passed
@liamhuber liamhuber deleted the remove_node_job branch August 8, 2024 22:02
@liamhuber liamhuber mentioned this pull request Aug 8, 2024
9 tasks
liamhuber added a commit that referenced this pull request Aug 8, 2024
* Remove all storage backends except for pickle

* Remove pyiron_contrib dependence and references

* Remove h5io_browser dependence

* Remove no-bidict workaround

It was only necessary for h5io since that can't handle bidict's custom reconstructor

* Remove channel recursion workaround

It was only necessary for h5io since that can't handle recursion. We keep the purging of connections, because those might actually extend the data scope by reaching non-owner nodes

* [minor] Remove node job (#415)

* Remove node job

* Remove pyiron_base and h5io dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant