Skip to content

Conversation

@samukweku
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • Fix test failures for pivot_longer and test__select_columns

This PR resolves #1154 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku samukweku requested a review from Zeroto521 August 20, 2022 07:59
@samukweku samukweku self-assigned this Aug 20, 2022
@ericmjl
Copy link
Member

ericmjl commented Aug 20, 2022

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #1155 (968c85d) into dev (a027753) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1155   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          77       77           
  Lines        3240     3240           
=======================================
  Hits         3154     3154           
  Misses         86       86           

Copy link
Member

@Zeroto521 Zeroto521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these new changes to test_pivot_longer.py passed in my local env (pandas 1.4.1)

@ericmjl ericmjl merged commit 78d4297 into dev Aug 20, 2022
@ericmjl
Copy link
Member

ericmjl commented Aug 20, 2022

Merged! 🎉 Thank you, @samukweku!

@Zeroto521 Zeroto521 deleted the samukweku/pivot_longer_fix branch November 2, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] pivot_longer test cases failed on pandas latest (1.4.x) passed on 1.3.x

4 participants