Skip to content

Conversation

@Zeroto521
Copy link
Member

@Zeroto521 Zeroto521 commented Oct 28, 2022

PR Description

Please describe the changes proposed in the pull request:

This PR resolves #(put issue number here, and remove parentheses).

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

jobs:
build-docs:
runs-on: ubuntu-latest
name: Build documentation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two same names are kind of duplicated
image

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1183 (98ed58e) into dev (f0c7906) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1183      +/-   ##
==========================================
+ Coverage   97.93%   97.96%   +0.02%     
==========================================
  Files          76       76              
  Lines        3387     3387              
==========================================
+ Hits         3317     3318       +1     
+ Misses         70       69       -1     

@ericmjl ericmjl merged commit 5ebf799 into pyjanitor-devs:dev Oct 29, 2022
@ericmjl
Copy link
Member

ericmjl commented Oct 29, 2022

Thank you, @Zeroto521! Astute eyes and great work figuring out how to simplify stuff!

@Zeroto521 Zeroto521 deleted the ci/merge-docs branch November 3, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants