-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] remove select_columns from conditional_join #1297
Conversation
🚀 Deployed on https://deploy-preview-1297--pyjanitor.netlify.app |
Codecov Report
@@ Coverage Diff @@
## dev #1297 +/- ##
==========================================
+ Coverage 92.84% 94.30% +1.45%
==========================================
Files 78 78
Lines 4125 4142 +17
==========================================
+ Hits 3830 3906 +76
+ Misses 295 236 -59 |
90822c5
to
32015f8
Compare
GitBot Summary of ChangesThe pull request includes several changes across multiple files, primarily focusing on enhancing the
cc: @samukweku, please check for correctness! |
@samukweku I think we're good to merge, right? I've already approved the changes, and all tests pass so far. |
@ericmjl yes it is ok to merge. Thanks |
PR Description
Please describe the changes proposed in the pull request:
select_columns
function from other functions/testsThis PR builds on #1288 .
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.