-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] improve performance for polars' complete
#1389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://deploy-preview-1389--pyjanitor.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1389 +/- ##
==========================================
- Coverage 94.48% 88.39% -6.09%
==========================================
Files 80 87 +7
Lines 4367 5352 +985
==========================================
+ Hits 4126 4731 +605
- Misses 241 621 +380 |
ericmjl
approved these changes
Jul 31, 2024
Looking great, @samukweku! Please do the honors of hitting the merge button! |
samukweku
added a commit
that referenced
this pull request
Aug 24, 2024
* remove ambiguity with structs * fix docs * pin numpy * fix docs * fix docs * add polars.expand * add polars.expand * add tests polars expand * pin setuptools * fix docs * fix docs * add extra test for polars expand * remove assumptions when fill_value is a dict * add test for pl.Series * fix column selection logic --------- Co-authored-by: samuel.oranyeli <samuel.oranyeli@grow.inc> Co-authored-by: Eric Ma <ericmjl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
collect_schema
instead ofcolumns
)This PR relates to #1352 .
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.