Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] improve performance for polars' complete #1389

Merged
merged 16 commits into from
Jul 31, 2024

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Jul 13, 2024

PR Description

Please describe the changes proposed in the pull request:

  • remove ambiguity for multiple columns - user creates a struct before calling complete
  • update code to remove performance warning ( uses collect_schema instead of columns)

This PR relates to #1352 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku samukweku self-assigned this Jul 13, 2024
@ericmjl
Copy link
Member

ericmjl commented Jul 13, 2024

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (62c57c6) to head (911abd8).
Report is 33 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1389      +/-   ##
==========================================
- Coverage   94.48%   88.39%   -6.09%     
==========================================
  Files          80       87       +7     
  Lines        4367     5352     +985     
==========================================
+ Hits         4126     4731     +605     
- Misses        241      621     +380     

@ericmjl
Copy link
Member

ericmjl commented Jul 31, 2024

Looking great, @samukweku! Please do the honors of hitting the merge button!

@samukweku samukweku merged commit 633c891 into dev Jul 31, 2024
4 checks passed
@samukweku samukweku deleted the samukweku/polars_complete_improve branch July 31, 2024 11:16
samukweku added a commit that referenced this pull request Aug 24, 2024
* remove ambiguity with structs

* fix docs

* pin numpy

* fix docs

* fix docs

* add polars.expand

* add polars.expand

* add tests polars expand

* pin setuptools

* fix docs

* fix docs

* add extra test for polars expand

* remove assumptions when fill_value is a dict

* add test for pl.Series

* fix column selection logic

---------

Co-authored-by: samuel.oranyeli <samuel.oranyeli@grow.inc>
Co-authored-by: Eric Ma <ericmjl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants