-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neptune.ai tracker #183
Conversation
References #182
Trigger CI
@PyKEEN-bot test plz |
@PyKEEN-bot Can you repeat those tests? |
@PyKEEN-bot Can you repeat those tests? |
@PyKEEN-bot one more time!!... test |
@migalkin thanks for taking a look. I had a few other ideas for trackers, some inspired by the list on PyTorch Lightning (https://github.com/PyTorchLightning/pytorch-lightning/tree/master/pytorch_lightning/loggers). Do you know any other services that might be worth adding? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to appveyor?
Besides I am fine with the changes.
P.S.: Four reviewers might be a bit wasteful 😅
AppVeyor doesn't want to play nicely and now we'll move to Github Actions completely |
just making sure everyone knows it's here 😅 I only needed one person to check it to make sure it didn't look crazy |
@lvermue do we need to run CI again? or are we sometimes okay with merging even if the tests didn't run on the last commit? |
@PyKEEN-bot Please test it one more time! |
@cthoyt You're right. But invoking it once more will show us how it'll react now that AppVeyor is gone |
Not sure how easy it is to implement this: Can we enforce running the full pipeline before the actual merge happens? So once you click squash and merge, it will first run the pipeline and only execute the merge when the pipeline passes. |
I haven't used Neptune (yet), there is indeed a huge variety of such trackers. Currently, I'd say ML Flow / WANDB / Neptune is a good enough gentleman set :) |
@mberr It should be that one can only choose to merge when everything is fine. This is now enforced. Squash and Merge is only available when the relevant checks have passed and the branch is up to date. |
@PyKEEN-bot tests ... one last time 😅 |
The current setup enforces that the last commit always has to be up to date and has to have passed all checks. I prefer this setup and think that it also is the golden standard to avoid any mistakes making its way to the master branch. |
Closes #182
This PR does the following:
pykeen.trackers
to be a subpackage since it was getting pretty full for a single fileFor review purposes, the only code you need to look at is
pykeen.trackers.neptune
and the tutorial. No other code has changed - it was just reorganized.