Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Complex interaction function #313

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Fix Complex interaction function #313

merged 3 commits into from
Feb 24, 2021

Conversation

mberr
Copy link
Member

@mberr mberr commented Feb 24, 2021

This PR fixes #312 .

  • The old-style model is affected
  • The new-style model is not affected.
  • A few of the (unused) complex variants were affected (those which use stacking).

@mberr
Copy link
Member Author

mberr commented Feb 24, 2021

@PyKEEN-bot please test

@cthoyt cthoyt merged commit 50c6016 into master Feb 24, 2021
@cthoyt cthoyt deleted the fix-complex-score branch February 24, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mali-git mali-git mali-git approved these changes

@cthoyt cthoyt cthoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The interaction_function of ComplEx is not what it should be
4 participants
@mberr @cthoyt @mali-git @PyKEEN-bot