🍇 🙏 Stop storing the training_instances as an instance variable #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PyKEEN-bot test |
cthoyt
changed the title
3 tasks
mberr
approved these changes
May 6, 2021
|
@PyKEEN-bot test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will simplify #417 by removing yet another unnecessary instance variable from the
TrainingLoopclass. Thetraining_instancesdo not actually need to be stored in state, since they only have to get passed around after callingTrainingLoop.train()This PR might also allow us to remove the triples_factory itself from many of these inner calls. This probably not the case, since the triples factor is used for two things: getting the number of triples (which isn't stored in the LCWA instances) and getting the mapped triples for graph sampling (which again isn't stored in the LCWA instances)