Replaced URLGrabber with requests (rhbz#1141245) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I forgot to incorporate changes in |
|
On the python2 case, can we somehow detect if the support is there and toggle SSL_VERIFY ourselves? |
|
@clumens Disabling SSL verification automatically is IMHO a very bad idea. I can modify the error message to advise the user to check this if the lib is run under PY2, but I'd generally advise against disabling it. |
|
Fixed issues and pushed an amended commit. |
Because urlgrabber is being dropped by many significant software projects in Fedora, Pykickstart can't keep depending on it once it is converted to Python 3 (rhbz#985310). This commit replaces the dep with requests with SSL verification turned on by default. This could pose trouble in Python 2 if proper underlying packages aren't installed [1]. In case this becomes a problem, the SSL_VERIFY constant in load.py may be switched to False. [1] https://github.com/kennethreitz/requests/issues/749#issuecomment-19187417
Merged
clumens
added a commit
that referenced
this pull request
Feb 17, 2015
Replaced URLGrabber with requests (rhbz#1141245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because urlgrabber is being dropped by many significant software projects in
Fedora, Pykickstart can't keep depending on it once it is converted to Python 3
(rhbz#985310).
This commit replaces the dep with requests with SSL verification turned on by
default. This could pose trouble in Python 2 if proper underlying packages
aren't installed [1]. In case this becomes a problem, the SSL_VERIFY constant
in constants.py may be switched to False.
[1] https://github.com/kennethreitz/requests/issues/749#issuecomment-19187417