Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash involving two starred expressions inside a call #1535

Merged
merged 3 commits into from
Apr 30, 2022

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Apr 30, 2022

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Before, there was an assumption that given an assign statement with a starred node on the right-hand side, there will be a container on the left-hand side. When the starred node is inside a call, that assumption is violated.

Type of Changes

Type
🐛 Bug fix

Related Issue

Refs pylint-dev/pylint#6372

@jacobtylerwalls jacobtylerwalls added Bug 🪳 needs-backport pylint-tested PRs that don't cause major regressions with pylint labels Apr 30, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.11.4 milestone Apr 30, 2022
@coveralls
Copy link

coveralls commented Apr 30, 2022

Pull Request Test Coverage Report for Build 2250509728

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.637%

Totals Coverage Status
Change from base Build 2250495577: 0.003%
Covered Lines: 9138
Relevant Lines: 9972

💛 - Coveralls

astroid/protocols.py Show resolved Hide resolved
astroid/protocols.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪳 pylint-tested PRs that don't cause major regressions with pylint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants