Skip to content

Move 3.11 to standard test job #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2022
Merged

Move 3.11 to standard test job #1584

merged 5 commits into from
Jun 2, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jun 1, 2022
@DanielNoord
Copy link
Collaborator Author

DanielNoord commented Jun 1, 2022 •
edited
Loading

The timing of this PR is quite good.

New beta of 3.11 seems to break our test, or pytest. Release was 9 hours ago:
https://github.com/actions/python-versions/releases/tag/3.11.0-beta.2-2419602742

Edit:
See pytest-dev/pytest#10011.

DanielNoord
DanielNoord commented Jun 1, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated
run: |
. venv/bin/activate
pytest --cov --cov-report= tests/
pytest --cov --cov-report= tests/ --assert=plain
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround as per:
pytest-dev/pytest#10008 (comment)

@coveralls
Copy link

coveralls commented Jun 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2428696261

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 91.884%
Files with Coverage Reduction New Missed Lines %
astroid/protocols.py 1 89.98%
astroid/inference.py 4 93.84%
Totals Coverage Status
Change from base Build 2416744317: -0.05%
Covered Lines: 9249
Relevant Lines: 10066
💛 - Coveralls

@DanielNoord
Copy link
Collaborator Author

This is blocking all CIs on all PRs, so would be good to merge this.

@DanielNoord
Copy link
Collaborator Author

A new beta was released. So the fix with --assert is no longer necessary 🎉

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @DanielNoord

@DanielNoord DanielNoord merged commit 3abd45e into pylint-dev:main Jun 2, 2022
@DanielNoord DanielNoord deleted the coverage branch June 2, 2022 14:03
@jacobtylerwalls jacobtylerwalls removed their request for review June 2, 2022 14:35
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas