Handle properties in dataclasses correctly #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
Dec 6, 2022
Comment on lines
+19
to
+21
| What's New in astroid 2.12.14? | ||
| ============================== | ||
| Release date: TBA |
There was a problem hiding this comment.
Suggested change
| What's New in astroid 2.12.14? | |
| ============================== | |
| Release date: TBA |
Let's release this in 2.13.0. #1189 is almost done.
There was a problem hiding this comment.
Would you be okay with me doing a patch release myself? I created quite a bit of regressions (and fixes) with the dataclass refactor. I'd like to get these out quickly as I depend on them in my day-to-day.
There was a problem hiding this comment.
Sure, might be the occasion to add the backporting github action to astroid.
There was a problem hiding this comment.
I'll leave that decision to you. This one should be fairly trivial to backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
Closes pylint-dev/pylint#5225
I intend to create some fixes for dataclasses in
astroid. I think it makes sense to do a patch release for them as they are small but useful fixes for a feature that gets used more and more.This is also out of self interest: I ran into this at my job 😅
Type of Changes