Fix PyPy ClassDef.fromlino with decorators
#1979
Conversation
| @@ -2139,9 +2139,10 @@ def _newstyle_impl(self, context: InferenceContext | None = None): | |||
| @cached_property | |||
| def fromlineno(self) -> int | None: | |||
| """The first line that this node appears on in the source code.""" | |||
| if not PY38_PLUS or PY38 and IS_PYPY: | |||
| if not PY38_PLUS or IS_PYPY and PY38 and not PYPY_7_3_11_PLUS: | |||
There was a problem hiding this comment.
Do we want to support multiple PyPy versions? I guess it's simple enough here, although I wouldn't add any more to CI.
There was a problem hiding this comment.
This feel like a lot of work but also added values. I guess on a case by case basis... ?
There was a problem hiding this comment.
This feel like a lot of work but also added values. I guess on a case by case basis... ?
Yeah, I was more referring to this specific case 😄
| @@ -15,6 +15,8 @@ Release date: TBA | |||
| * Fix issues with ``typing_extensions.TypeVar``. | |||
|
|
|||
|
|
|||
| * Fix ``ClassDef.fromlino`` for PyPy 3.8 (v7.3.11) if class is wrapped by a decorator. | |||
There was a problem hiding this comment.
I can move this to 2.14.0 if we want to skip 2.13.4.
There was a problem hiding this comment.
Let's not skip, releasing is cheap (compared to fixing the milestones)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 94 94
Lines 10902 10903 +1
=======================================
+ Hits 10101 10102 +1
Misses 801 801
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit dfd88f5)
Description
Followup to #1910
Never got around to reviewing it in time unfortunately.
The last PyPy release for 3.8 (v7.3.11) actually provided a fix for the ast lineno issue and is now compliant with the cpython implementation.
https://doc.pypy.org/en/latest/release-v7.3.11.html#python-3-8
/CC: @Pierre-Sassoulas