Skip recursion test on PyPy #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1987 +/- ##
==========================================
- Coverage 92.64% 92.53% -0.12%
==========================================
Files 94 94
Lines 10894 10891 -3
==========================================
- Hits 10093 10078 -15
- Misses 801 813 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This seems to resolve the issue. All 5 successive CI runs finished without failure. |
DanielNoord
approved these changes
Jan 29, 2023
DanielNoord
requested changes
Jan 29, 2023
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
DanielNoord
approved these changes
Jan 29, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jan 29, 2023
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> (cherry picked from commit c1e4c95)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #1984 (comment) and #1986
Skip recursion test on PyPy, since it can sometimes raise a
RecursionErrorwhen run with coverage enabled.