Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infer_call_result() crash on methods called with_metaclass() #2118

Merged
merged 3 commits into from
Apr 15, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes #1735

@jacobtylerwalls jacobtylerwalls added this to the 2.15.3 milestone Apr 15, 2023
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #2118 (65b09d5) into main (495581f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2118   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          94       94           
  Lines       10955    10958    +3     
=======================================
+ Hits        10167    10170    +3     
  Misses        788      788           
Flag Coverage Δ
linux 92.52% <100.00%> (+<0.01%) ⬆️
pypy 88.09% <100.00%> (+<0.01%) ⬆️
windows 92.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
astroid/nodes/scoped_nodes/scoped_nodes.py 93.09% <100.00%> (+0.01%) ⬆️

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code for supporting with_metaclass seems broken
2 participants