Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various TryStar fixes #2142

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 24, 2023

Description

  • Add string visitor function for TryStar nodes.
  • Add TryStar to ALL_NODE_CLASSES and __all__

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (maintenance/2.15.x@c312218). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##             maintenance/2.15.x    #2142   +/-   ##
=====================================================
  Coverage                      ?   92.84%           
=====================================================
  Files                         ?       95           
  Lines                         ?    11089           
  Branches                      ?        0           
=====================================================
  Hits                          ?    10296           
  Misses                        ?      793           
  Partials                      ?        0           
Flag Coverage Δ
linux 92.56% <0.00%> (?)
pypy 88.01% <0.00%> (?)
windows 92.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! How did you find out that this was required ? Is this just your general knowledge of what's required in astroid ?

@cdce8p
Copy link
Member Author

cdce8p commented Apr 24, 2023

Thank you ! How did you find out that this was required ? Is this just your general knowledge of what's required in astroid ?

I was looking at #1867 and noticed that TryStar was missing in a bunch of places where TryExcept / TryFinally where (and a bit of knowledge about how the nodes work).

@cdce8p cdce8p merged commit 7348293 into pylint-dev:maintenance/2.15.x Apr 24, 2023
@cdce8p cdce8p deleted the fix-trystar branch April 24, 2023 05:24
@github-actions
Copy link
Contributor

The backport to maintenance/2.15.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-2142-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73482936a4eabeb3e51425f3b5c56d1d9e0a9bb9
# Push it to GitHub
git push --set-upstream origin backport-2142-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x

Then, create a pull request where the base branch is maintenance/2.15.x and the compare/head branch is backport-2142-to-maintenance/2.15.x.

@cdce8p
Copy link
Member Author

cdce8p commented Apr 24, 2023

Seems like targeted the wrong branch though 😞
Guess this will be merged into main after the release anyway.

@Pierre-Sassoulas
Copy link
Member

Did you want to fix 2.15.4 ? I think it's targeted in the right branch but there was a conflict during the cherry-pick so it needs to be applied manually ?

@cdce8p
Copy link
Member Author

cdce8p commented Apr 24, 2023

The fix should be in both main and maintenance/2.15.x. I mistakenly targeted the later, so the backport will of course fail (this is the backport PR essentially). I just need to get these changes into main now, either through a merge or via a separate PR.

@Pierre-Sassoulas
Copy link
Member

Ha, right ! Yes, let's release 2.15.4 directly then.

@cdce8p
Copy link
Member Author

cdce8p commented Apr 24, 2023

Ha, right ! Yes, let's release 2.15.4 directly then.

Done in #2144 and merged into main in #2145. All good now

@Pierre-Sassoulas
Copy link
Member

Thank you for releasing so fast, Marc 🚀 !

@Pierre-Sassoulas Pierre-Sassoulas added backported Assigned once the backport is done and removed backport maintenance/2.15.x labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast backported Assigned once the backport is done Bug 🪳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants