Complete cache key for inference tip #2158

jacobtylerwalls · 2023-04-30T13:52:13Z

Type of Changes

	Type
✓	🐛 Bug fix

Description

As identified by @kriek in #1828, part of the cache key (context) was missing.

Alternative to #1832, which removes the cache, this just adds the missing part of the key.

Closes #1828
Closes pylint-dev/pylint#7464
Closes pylint-dev/pylint#8074

Refs #1982 (reverted)

Pylint test

The following diff in pylint will (almost) pass the test suite with this change. ~~PR shortly.~~ PR once I can debug the remaining failures with deprecated_typing_alias.

diff --git a/pylint/checkers/design_analysis.py b/pylint/checkers/design_analysis.py
index 701615d89..d605aed76 100644
--- a/pylint/checkers/design_analysis.py
+++ b/pylint/checkers/design_analysis.py
@@ -166,6 +166,8 @@ STDLIB_CLASSES_IGNORE_ANCESTOR = frozenset(
         "typing.AsyncContextManager",
         "typing.Hashable",
         "typing.Sized",
+        TYPING_NAMEDTUPLE,
+        TYPING_TYPEDDICT,
     )
 )

The cache key was lacking the `context` arg Co-authored-by: Sylvain Ackermann <sylvain.ackermann@gmail.com>

codecov · 2023-04-30T13:58:56Z

Codecov Report

Merging #2158 (a79a2a7) into main (06fafc4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2158   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files          94       94           
  Lines       10800    10804    +4     
=======================================
+ Hits         9994     9998    +4     
  Misses        806      806

Flag	Coverage Δ
linux	`92.29% <100.00%> (+<0.01%)`	⬆️
pypy	`87.48% <100.00%> (+<0.01%)`	⬆️
windows	`92.13% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
astroid/inference_tip.py	`97.36% <100.00%> (+0.30%)`	⬆️

astroid/inference_tip.py

DanielNoord

Test improvements look nice!

jacobtylerwalls · 2023-04-30T14:25:22Z

Unfortunately it has the same problem in pypy with RecursionError identified in #2002, see https://github.com/jacobtylerwalls/pylint/actions/runs/4844716534/jobs/8633169007?pr=10.

Seems like the right approach, though, so we need to just deal with the RecursionError or something.

jacobtylerwalls · 2023-04-30T14:42:00Z

More history!

The test in question was skipped in #1984, then the skip was removed in #2000 when the decision was made to revert the substantive change dating to #1982.

Pierre-Sassoulas

Nice long-awaited improvements seeing the modification in the tests 😄

Pierre-Sassoulas · 2023-04-30T15:40:18Z

tests/brain/test_brain.py

@@ -954,7 +948,7 @@ def ident(var: T) -> T:

        i1 = next(ast_nodes[1].infer())
        assert isinstance(i1, nodes.Const)
-        assert i1.value == 2  # should be "Hello"!
+        assert i1.value == "Hello"


jacobtylerwalls · 2023-04-30T15:49:43Z

Sorry for the noise, I'm experimenting to see if I can get the recursion error in pypy to resolve.

for more information, see https://pre-commit.ci

jacobtylerwalls · 2023-04-30T17:36:42Z

RecursionError in PyPy fixed, see run on my fork failing on something else (compare to earlier run failing with RecursionError).

Pierre-Sassoulas

You've been contributing some serious improvements in perf/caching -that astroid and pylint needs most- @jacobtylerwalls, amazing 👌

astroid/inference_tip.py

Pierre-Sassoulas · 2023-05-06T13:34:30Z

The readthedoc fail could be fixed by pinning urllib3 to < 2 it seems ?

jacobtylerwalls · 2023-05-06T13:58:56Z

Others have solved it by ensuring Python 3.9 or higher is used for the build. Can we do that in a read the docs .yml?

jacobtylerwalls · 2023-05-06T14:00:59Z

Suggestions!

Fix read the docs in Use Python 3.11 for Read the Docs build #2165
I merge that here, someone approves this
Squash merge this
I open a new PR I just finished to improve the typing in this file: Improve typing of inference functions #2166

astroid/inference_tip.py

Complete cache key for inference tip

d1b73d1

The cache key was lacking the `context` arg Co-authored-by: Sylvain Ackermann <sylvain.ackermann@gmail.com>

jacobtylerwalls added the pylint-tested PRs that don't cause major regressions with pylint label Apr 30, 2023

jacobtylerwalls added this to the 3.0.0a3 milestone Apr 30, 2023

jacobtylerwalls requested a review from cdce8p April 30, 2023 13:52

jacobtylerwalls mentioned this pull request Apr 30, 2023

Remove inference tip cache #1832

Closed

DanielNoord reviewed Apr 30, 2023

View reviewed changes

astroid/inference_tip.py Outdated Show resolved Hide resolved

Adjust type annotation

171c48b

DanielNoord previously approved these changes Apr 30, 2023

View reviewed changes

Add is_empty() to InferenceContext

0771987

jacobtylerwalls dismissed DanielNoord’s stale review via 0771987 April 30, 2023 15:39

Pierre-Sassoulas previously approved these changes Apr 30, 2023

View reviewed changes

fixup! Add is_empty()

370b630

jacobtylerwalls dismissed Pierre-Sassoulas’s stale review via 370b630 April 30, 2023 15:50

jacobtylerwalls removed the pylint-tested PRs that don't cause major regressions with pylint label Apr 30, 2023

jacobtylerwalls and others added 6 commits April 30, 2023 12:32

Add __hash__() and __eq__() to InferenceContext

38955bf

[pre-commit.ci] auto fixes from pre-commit.com hooks

b923101

for more information, see https://pre-commit.ci

fixup! Add __hash__

04b0735

Restore the recursion guard using a partial cache key

d8a810f

Remove __eq__() and __hash__()

cb5b291

fixup! Restore

e054f40

jacobtylerwalls added the pylint-tested PRs that don't cause major regressions with pylint label Apr 30, 2023

Pierre-Sassoulas previously approved these changes Apr 30, 2023

View reviewed changes

DanielNoord reviewed May 1, 2023

View reviewed changes

astroid/inference_tip.py Show resolved Hide resolved

Add comment.

e735438

jacobtylerwalls dismissed Pierre-Sassoulas’s stale review via e735438 May 6, 2023 12:31

Remove assertion

0fa0233

Merge branch 'main' into incomplete-cache-key

30f249d

jacobtylerwalls commented May 6, 2023

View reviewed changes

astroid/inference_tip.py Outdated Show resolved Hide resolved

Remove optionality of list[InferenceResult]

a79a2a7

jacobtylerwalls requested a review from Pierre-Sassoulas May 6, 2023 14:59

Pierre-Sassoulas approved these changes May 6, 2023

View reviewed changes

jacobtylerwalls removed the request for review from cdce8p May 6, 2023 15:16

jacobtylerwalls merged commit 0740a0d into pylint-dev:main May 6, 2023

jacobtylerwalls deleted the incomplete-cache-key branch May 6, 2023 15:17

jacobtylerwalls mentioned this pull request May 6, 2023

Improve typing of inference functions #2166

Merged

This was referenced May 14, 2023

Inference tip cache is unbounded #2180

Closed

Add a bound to the inference tips cache (and fix regressions from #2158) #2181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete cache key for inference tip #2158

Complete cache key for inference tip #2158

jacobtylerwalls commented Apr 30, 2023 •

edited

Loading

codecov bot commented Apr 30, 2023 •

edited

Loading

DanielNoord left a comment

jacobtylerwalls commented Apr 30, 2023 •

edited

Loading

jacobtylerwalls commented Apr 30, 2023

Pierre-Sassoulas left a comment

Pierre-Sassoulas Apr 30, 2023

jacobtylerwalls commented Apr 30, 2023

jacobtylerwalls commented Apr 30, 2023

Pierre-Sassoulas left a comment

Pierre-Sassoulas commented May 6, 2023

jacobtylerwalls commented May 6, 2023

jacobtylerwalls commented May 6, 2023 •

edited

Loading

Complete cache key for inference tip #2158

Complete cache key for inference tip #2158

Conversation

jacobtylerwalls commented Apr 30, 2023 • edited Loading

Type of Changes

Description

Pylint test

codecov bot commented Apr 30, 2023 • edited Loading

Codecov Report

DanielNoord left a comment

Choose a reason for hiding this comment

jacobtylerwalls commented Apr 30, 2023 • edited Loading

jacobtylerwalls commented Apr 30, 2023

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas Apr 30, 2023

Choose a reason for hiding this comment

jacobtylerwalls commented Apr 30, 2023

jacobtylerwalls commented Apr 30, 2023

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented May 6, 2023

jacobtylerwalls commented May 6, 2023

jacobtylerwalls commented May 6, 2023 • edited Loading

jacobtylerwalls commented Apr 30, 2023 •

edited

Loading

codecov bot commented Apr 30, 2023 •

edited

Loading

jacobtylerwalls commented Apr 30, 2023 •

edited

Loading

jacobtylerwalls commented May 6, 2023 •

edited

Loading