Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport maintenance/2.15.x] Infer user-defined enum classes by checking if the class is a subtype of enum.Enum #2298

Merged
merged 1 commit into from
Sep 23, 2023
Merged

[Backport maintenance/2.15.x] Infer user-defined enum classes by checking if the class is a subtype of enum.Enum #2298

merged 1 commit into from
Sep 23, 2023

Conversation

jacobtylerwalls
Copy link
Member

Backport of #2277

@mbyrnepr2 @jacobtylerwalls
Infer user-defined enum classes by checking if the class is a subtype…
27280f9 
… of ``enum.Enum`` (#2277)

(cherry picked from commit c5352d5)
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwalls jacobtylerwalls added this to the 2.15.7 milestone Sep 23, 2023
@jacobtylerwalls jacobtylerwalls changed the title [Backport maintenance/2.17.x] Infer user-defined enum classes by checking if the class is a subtype of enum.Enum [Backport maintenance/2.15.x] Infer user-defined enum classes by checking if the class is a subtype of enum.Enum Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #2298 (27280f9) into maintenance/2.15.x (554d93e) will increase coverage by 0.10%.
Report is 9 commits behind head on maintenance/2.15.x.
The diff coverage is 96.66%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           maintenance/2.15.x    #2298      +/-   ##
======================================================
+ Coverage               92.84%   92.95%   +0.10%     
======================================================
  Files                      95       95              
  Lines                   11089    11102      +13     
======================================================
+ Hits                    10296    10320      +24     
+ Misses                    793      782      -11
Flag Coverage Δ
linux 92.67% <96.66%> (+0.10%) ⬆️
pypy 88.09% <96.66%> (+0.07%) ⬆️
windows 92.51% <96.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
astroid/manager.py 89.95% <91.66%> (+1.74%) ⬆️
astroid/__pkginfo__.py 100.00% <100.00%> (ø)
astroid/brain/brain_functools.py 98.70% <100.00%> (+0.03%) ⬆️
astroid/brain/brain_namedtuple_enum.py 92.88% <100.00%> (-0.10%) ⬇️
astroid/brain/brain_typing.py 88.43% <100.00%> (ø)
astroid/inference.py 94.60% <100.00%> (+0.01%) ⬆️
astroid/modutils.py 89.43% <100.00%> (+2.11%) ⬆️
astroid/protocols.py 90.72% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

mbyrnepr2
mbyrnepr2 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@mbyrnepr2 mbyrnepr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the coverage seems to decrease for this.

@jacobtylerwalls
Copy link
Member Author

Yeah, the miscalculation has been happening on several PRs.

@jacobtylerwalls jacobtylerwalls merged commit 1f62beb into maintenance/2.15.x Sep 23, 2023
16 of 17 checks passed
@jacobtylerwalls jacobtylerwalls deleted the backport-2277 branch September 23, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbyrnepr2 mbyrnepr2 mbyrnepr2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @mbyrnepr2