Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge maintenance following 3.3.7 release #2660

Merged
merged 3 commits into from
Dec 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions CONTRIBUTORS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ Maintainers
-----------
- Pierre Sassoulas <pierre.sassoulas@gmail.com>
- Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
- Hippo91 <guillaume.peillex@gmail.com>
- Marc Mueller <30130371+cdce8p@users.noreply.github.com>
- Jacob Walls <jacobtylerwalls@gmail.com>
- Marc Mueller <30130371+cdce8p@users.noreply.github.com>
- Hippo91 <guillaume.peillex@gmail.com>
- Bryce Guinta <bryce.paul.guinta@gmail.com>
- Ceridwen <ceridwenv@gmail.com>
- Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
Expand All @@ -32,27 +32,33 @@ Contributors
------------
- Emile Anclin <emile.anclin@logilab.fr>
- Nick Drozd <nicholasdrozd@gmail.com>
- correctmost <134317971+correctmost@users.noreply.github.com>
- Andrew Haigh <hello@nelf.in>
- Julien Cristau <julien.cristau@logilab.fr>
- David Liu <david@cs.toronto.edu>
- Alexandre Fayolle <alexandre.fayolle@logilab.fr>
- Eevee (Alex Munroe) <amunroe@yelp.com>
- temyurchenko <44875844+temyurchenko@users.noreply.github.com>
- David Gilman <davidgilman1@gmail.com>
- Tushar Sadhwani <tushar.sadhwani000@gmail.com>
- Julien Jehannet <julien.jehannet@logilab.fr>
- Calen Pennington <calen.pennington@gmail.com>
- Antonio <antonio@zoftko.com>
- Hugo van Kemenade <hugovk@users.noreply.github.com>
- Artem Yurchenko <artemyurchenko@zoho.com>
- Tim Martin <tim@asymptotic.co.uk>
- Phil Schaf <flying-sheep@web.de>
- Alex Hall <alex.mojaki@gmail.com>
- Raphael Gaschignard <raphael@makeleaps.com>
- Radosław Ganczarek <radoslaw@ganczarek.in>
- Paligot Gérard <androwiiid@gmail.com>
- Ioana Tagirta <ioana.tagirta@gmail.com>
- Eric Vergnaud <eric.vergnaud@wanadoo.fr>
- Derek Gustafson <degustaf@gmail.com>
- David Shea <dshea@redhat.com>
- Daniel Harding <dharding@gmail.com>
- Christian Clauss <cclauss@me.com>
- Akhil Kamat <akhil.kamat@gmail.com>
- Ville Skyttä <ville.skytta@iki.fi>
- Rene Zhang <rz99@cornell.edu>
- Philip Lorenz <philip@bithub.de>
Expand All @@ -65,12 +71,12 @@ Contributors
- FELD Boris <lothiraldan@gmail.com>
- Enji Cooper <yaneurabeya@gmail.com>
- Dani Alcala <112832187+clavedeluna@users.noreply.github.com>
- Antonio <antonio@zoftko.com>
- Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
- tristanlatr <19967168+tristanlatr@users.noreply.github.com>
- emile@crater.logilab.fr <emile@crater.logilab.fr>
- doranid <ddandd@gmail.com>
- brendanator <brendan.maginnis@gmail.com>
- akamat10 <akhil.kamat@gmail.com>
- Tomas Gavenciak <gavento@ucw.cz>
- Tim Paine <t.paine154@gmail.com>
- Thomas Hisch <t.hisch@gmail.com>
Expand Down Expand Up @@ -129,29 +135,36 @@ Contributors
- Peter de Blanc <peter@standard.ai>
- Peter Talley <peterctalley@gmail.com>
- Ovidiu Sabou <ovidiu@sabou.org>
- Oleh Prypin <oleh@pryp.in>
- Nicolas Noirbent <nicolas@noirbent.fr>
- Neil Girdhar <mistersheik@gmail.com>
- Miro Hrončok <miro@hroncok.cz>
- Michał Masłowski <m.maslowski@clearcode.cc>
- Mateusz Bysiek <mb@mbdev.pl>
- Matej Aleksandrov <matej.aleksandrov@gmail.com>
- Marcelo Trylesinski <marcelotryle@gmail.com>
- Leandro T. C. Melo <ltcmelo@gmail.com>
- Konrad Weihmann <kweihmann@outlook.com>
- Kian Meng, Ang <kianmeng.ang@gmail.com>
- Kai Mueller <15907922+kasium@users.noreply.github.com>
- Jörg Thalheim <Mic92@users.noreply.github.com>
- Jérome Perrin <perrinjerome@gmail.com>
- JulianJvn <128477611+JulianJvn@users.noreply.github.com>
- Josef Kemetmüller <josef.kemetmueller@gmail.com>
- Jonathan Striebel <jstriebel@users.noreply.github.com>
- John Belmonte <john@neggie.net>
- Jeff Widman <jeff@jeffwidman.com>
- Jeff Quast <contact@jeffquast.com>
- Jarrad Hope <me@jarradhope.com>
- Jared Garst <jgarst@users.noreply.github.com>
- Jamie Scott <jamie@jami.org.uk>
- Jakub Wilk <jwilk@jwilk.net>
- Iva Miholic <ivamiho@gmail.com>
- Ionel Maries Cristian <contact@ionelmc.ro>
- HoverHell <hoverhell@gmail.com>
- Hashem Nasarat <Hnasar@users.noreply.github.com>
- HQupgradeHQ <18361586+HQupgradeHQ@users.noreply.github.com>
- Gwyn Ciesla <gwync@protonmail.com>
- Grygorii Iermolenko <gyermolenko@gmail.com>
- Gregory P. Smith <greg@krypto.org>
- Giuseppe Scrivano <gscrivan@redhat.com>
Expand Down Expand Up @@ -191,8 +204,6 @@ Contributors
- Alexander Scheel <alexander.m.scheel@gmail.com>
- Alexander Presnyakov <flagist0@gmail.com>
- Ahmed Azzaoui <ahmed.azzaoui@engie.com>
- JulianJvn <128477611+JulianJvn@users.noreply.github.com>
- Gwyn Ciesla <gwync@protonmail.com>

Co-Author
---------
Expand Down
9 changes: 8 additions & 1 deletion ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,17 @@ Release date: TBA
Closes #2513


What's New in astroid 3.3.7?
What's New in astroid 3.3.8?
============================
Release date: TBA




What's New in astroid 3.3.7?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're duplicating this entry in 3.3.8. It happened with the last release as well.

============================
Release date: 2024-12-20

* Fix inability to import `collections.abc` in python 3.13.1. The reported fix in astroid 3.3.6
did not actually fix this issue.

Expand Down
10 changes: 6 additions & 4 deletions astroid/interpreter/_import/spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,13 +386,15 @@ def _search_zip(
if PY310_PLUS:
if not importer.find_spec(os.path.sep.join(modpath)):
raise ImportError(
"No module named %s in %s/%s"
% (".".join(modpath[1:]), filepath, modpath)
"No module named {} in {}/{}".format(
".".join(modpath[1:]), filepath, modpath
)
)
elif not importer.find_module(os.path.sep.join(modpath)):
raise ImportError(
"No module named %s in %s/%s"
% (".".join(modpath[1:]), filepath, modpath)
"No module named {} in {}/{}".format(
".".join(modpath[1:]), filepath, modpath
)
)
return (
ModuleType.PY_ZIPMODULE,
Expand Down
Loading