Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astroid 2.5.0 #872

Merged
merged 14 commits into from
Dec 29, 2020
Merged

Astroid 2.5.0 #872

merged 14 commits into from
Dec 29, 2020

Conversation

hippo91
Copy link
Contributor

@hippo91 hippo91 commented Dec 27, 2020

Steps

  • Write a good description on what the PR does.

Description

This is a PR for future 2.5.0 version.
When merged we wiil have to do the 4-5 and 6 steps of the release.txt file.

@hippo91
Copy link
Contributor Author

hippo91 commented Dec 27, 2020

@PCManticore have you got an idea on how to put a deprecation warning when astroid is used with python3.5?

@Pierre-Sassoulas
Copy link
Member

@hippo91, regarding the deprecation warning I would use the following in setup.py:

import sys
import warnings

if sys.version_info.major == 3 and sys.version_info.minor <=5:
    warnings.warn("You will soon need to upgrade to python 3.6 in order to use the latest version of Astroid.", DeprecationWarning)

@hippo91
Copy link
Contributor Author

hippo91 commented Dec 27, 2020

@Pierre-Sassoulas definitely a good idea! The message will be printed during install and not at runtime. It's probably sufficient.

Copy link
Contributor

@PCManticore PCManticore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but ideally we should remove or change the release date to today.

ChangeLog Outdated
@@ -5,8 +5,7 @@ astroid's ChangeLog

What's New in astroid 2.5.0?
============================
Release Date: TBA

Release Date: 2020-12-27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already obsolete. My suggestion is to simply backport the code changes but keep the __pkginfo__ and ChangeLog for a separate change in the day of the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PCManticore i will move back the Release Date in the ChangeLog. However i didn't change the __pkginfo__.
By the way, have you an idea concerning the release date? There are many people waiting for a release that support python 3.9.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Not right now. I am still going through the latest updates, mails and issues and don't have a clear picture on what's needed for Python 3.9 compatibility. I did notice some Python 3.9 issues specific to pylint though.

astroid/modutils.py Outdated Show resolved Hide resolved
@hippo91 hippo91 merged commit 99d9c77 into pylint-dev:master Dec 29, 2020
@hippo91 hippo91 deleted the astroid_2.5.0 branch December 29, 2020 13:53
@FRidh
Copy link

FRidh commented Jan 4, 2021

Could there be a tag and PyPI release?


Ah, just preparatory changes only it seems.

@FRidh FRidh mentioned this pull request Jan 4, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants