-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astroid 2.5.0 #872
Astroid 2.5.0 #872
Conversation
@PCManticore have you got an idea on how to put a deprecation warning when |
@hippo91, regarding the deprecation warning I would use the following in
|
@Pierre-Sassoulas definitely a good idea! The message will be printed during install and not at runtime. It's probably sufficient. |
…e base_prefix instead
…rue) with pypy is to specifiy the prefix = sys.base_prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but ideally we should remove or change the release date to today.
ChangeLog
Outdated
@@ -5,8 +5,7 @@ astroid's ChangeLog | |||
|
|||
What's New in astroid 2.5.0? | |||
============================ | |||
Release Date: TBA | |||
|
|||
Release Date: 2020-12-27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already obsolete. My suggestion is to simply backport the code changes but keep the __pkginfo__
and ChangeLog
for a separate change in the day of the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PCManticore i will move back the Release Date in the ChangeLog. However i didn't change the __pkginfo__
.
By the way, have you an idea concerning the release date? There are many people waiting for a release that support python 3.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Not right now. I am still going through the latest updates, mails and issues and don't have a clear picture on what's needed for Python 3.9 compatibility. I did notice some Python 3.9 issues specific to pylint
though.
Could there be a tag and PyPI release? Ah, just preparatory changes only it seems. |
Steps
Description
This is a PR for future 2.5.0 version.
When merged we wiil have to do the 4-5 and 6 steps of the release.txt file.