Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up compat #205

Closed
carlio opened this issue Nov 26, 2018 · 3 comments
Closed

Tidy up compat #205

carlio opened this issue Nov 26, 2018 · 3 comments

Comments

@carlio
Copy link
Member

carlio commented Nov 26, 2018

As part of #201 #203 fixes in #204 I just added the old compat.py back in.

I only used the YES==Uninferable for now but I did not revert any other changes as they clearly work.

Since this library has open ended ranges, I think it is useful to have a single place to put the various hacks/workarounds that come from supporting pylint==2.1->pylint==latest as is the current case.

Ideally all those hacks should go into the same place for easy of cleaning. The previous code (and the code that is now there) were not really cleaned out enough and there's lots of unecessary bits.

This issues is to:

  1. clear out the previous legacy things which are no longer useful due to not supporting ancient pylint versions, eg the method mis-spellings
  2. figure out how to add new fixes for newer pylint/astroid etc releases.

The fact is that as pylint-django is used in lots of build processes in lots of configurations, any time there is a bug due to bad code in pylint-django or upstream changes, lots of people will waste time figuring out why their builds now error and we will get bug reports. It's in the best interests of everyone to have a good strategy to cope with this - trust me from 5 years of this :-)

@atodorov That is mostly for you to read

@atodorov
Copy link
Contributor

See #206 (I didn't see this notification after I submitted the PR)

@carlio
Copy link
Member Author

carlio commented Jan 2, 2019

Think this can be closed for now as we've ended up on a solution - more specific issues would be better? @atodorov

@atodorov
Copy link
Contributor

atodorov commented Jan 2, 2019

no objections on my side

@carlio carlio closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants