-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up compat #205
Labels
Comments
See #206 (I didn't see this notification after I submitted the PR) |
carlio
pushed a commit
that referenced
this issue
Nov 29, 2018
carlio
pushed a commit
that referenced
this issue
Nov 29, 2018
carlio
pushed a commit
that referenced
this issue
Nov 29, 2018
atodorov
pushed a commit
that referenced
this issue
Dec 14, 2018
atodorov
pushed a commit
that referenced
this issue
Dec 14, 2018
atodorov
pushed a commit
that referenced
this issue
Dec 14, 2018
Think this can be closed for now as we've ended up on a solution - more specific issues would be better? @atodorov |
no objections on my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #201 #203 fixes in #204 I just added the old
compat.py
back in.I only used the
YES
==Uninferable
for now but I did not revert any other changes as they clearly work.Since this library has open ended ranges, I think it is useful to have a single place to put the various hacks/workarounds that come from supporting
pylint==2.1
->pylint==latest
as is the current case.Ideally all those hacks should go into the same place for easy of cleaning. The previous code (and the code that is now there) were not really cleaned out enough and there's lots of unecessary bits.
This issues is to:
The fact is that as pylint-django is used in lots of build processes in lots of configurations, any time there is a bug due to bad code in pylint-django or upstream changes, lots of people will waste time figuring out why their builds now error and we will get bug reports. It's in the best interests of everyone to have a good strategy to cope with this - trust me from 5 years of this :-)
@atodorov That is mostly for you to read
The text was updated successfully, but these errors were encountered: