Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pylint v3 and drop v1 #27

Merged
merged 4 commits into from
Dec 3, 2023
Merged

Support pylint v3 and drop v1 #27

merged 4 commits into from
Dec 3, 2023

Conversation

anis-campos
Copy link

@anis-campos anis-campos commented Dec 1, 2023

in pylint v3.0.0, there is pylint-dev/pylint#8404, that breaks the current implementation of:

  • ClassAttrLoader
  • FixtureChecker

This fix is an attempt of supporting both pylint v2 and v3.

Other chances:

  • remove the support of pylint v1 (was only possible in python 3.6. and seems to be broken)
  • use pylint v3 to check the source code

Fixes #12

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc8fa90) 92.50% compared to head (1195f5c) 94.16%.

❗ Current head 1195f5c differs from pull request most recent head a9a022f. Consider uploading reports for the commit a9a022f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   92.50%   94.16%   +1.66%     
==========================================
  Files          18       18              
  Lines         560      548      -12     
  Branches      109      106       -3     
==========================================
- Hits          518      516       -2     
+ Misses         29       23       -6     
+ Partials       13        9       -4     
Flag Coverage Δ
3.10 93.97% <100.00%> (+1.65%) ⬆️
3.11 93.97% <100.00%> (+1.65%) ⬆️
3.6 93.97% <100.00%> (+1.65%) ⬆️
3.7 93.97% <100.00%> (+1.65%) ⬆️
3.8 93.97% <100.00%> (+1.65%) ⬆️
3.9 93.97% <100.00%> (+1.65%) ⬆️
macos-latest 93.97% <100.00%> (+1.65%) ⬆️
ubuntu-20.04 93.97% <100.00%> (+1.65%) ⬆️
ubuntu-latest 93.97% <100.00%> (+1.65%) ⬆️
windows-latest 93.97% <100.00%> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anis-campos anis-campos mentioned this pull request Dec 1, 2023
setup.py Show resolved Hide resolved
in pylint v3.0.0, there is pylint-dev/pylint#8404, that breaks the current implementation of:
- ClassAttrLoader
- FixtureChecker
This fix is an attempt of supporting both pylint v2 and v3
@anis-campos
Copy link
Author

@stdedos , sorry if I overstepped with my last commit. I did it as I was a little confused by the non-deterministic state of the dependencies (specially pylint, where the CI was using v3 and my local vas using v2).

let me know if I should place it in another PR

Anis Da Silva Campos and others added 2 commits December 1, 2023 15:10
not needed anymore now that we require >=v2
Fix `pylint` configuration for v3

https://pylint.pycqa.org/en/latest/whatsnew/3/3.0/index.html#changes-requiring-user-actions

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@anis-campos anis-campos changed the title Support pylint v3 Support pylint >=v2 Dec 1, 2023
@anis-campos anis-campos changed the title Support pylint >=v2 Support pylint v3 and drop v1 Dec 1, 2023
@stdedos
Copy link
Collaborator

stdedos commented Dec 1, 2023

Uuum, definitely some changes need to be rationalized to be merged in this PR 😅

I'll try to review quickly tonight.
However, even if this gets accepted as-is, release will happen earliest Monday (I don't want to give weekend surprises to anyone 😅)

@stdedos
Copy link
Collaborator

stdedos commented Dec 2, 2023

Yeah, I have "quite a few" questions wrt 87baf06.
Definitely I do not think it belongs to this PR.

Please force-push revert it, so we can merge this.

OTOH, thank you very much for showing this: It was a mash-up of TILs for me 🙃
And one of them (constraints) would've been a lot helpful ... 1-2y ago 😅

@anis-campos
Copy link
Author

anis-campos commented Dec 3, 2023

Yeah, I have "quite a few" questions wrt 87baf06. Definitely I do not think it belongs to this PR.

Please force-push revert it, so we can merge this.

OTOH, thank you very much for showing this: It was a mash-up of TILs for me 🙃 And one of them (constraints) would've been a lot helpful ... 1-2y ago 😅

Ok, done. I will re-submit the dependency management part in a later PR, let's just keep in mind that some differences might show up in between local and CI depending of the dependencies version, specially pylint v2/v3.

@stdedos stdedos added the bug Something isn't working label Dec 3, 2023
@stdedos stdedos added this to the Release v1.1.x milestone Dec 3, 2023
Copy link
Collaborator

@stdedos stdedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😄

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@stdedos stdedos merged commit 48212e2 into pylint-dev:master Dec 3, 2023
21 checks passed
@anis-campos anis-campos deleted the support-pylint-3 branch December 3, 2023 22:29
stdedos added a commit that referenced this pull request Dec 4, 2023
* Support pylint v3 and drop v1 (#27)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pylint v3
2 participants