-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pylint v3 and drop v1 #27
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 92.50% 94.16% +1.66%
==========================================
Files 18 18
Lines 560 548 -12
Branches 109 106 -3
==========================================
- Hits 518 516 -2
+ Misses 29 23 -6
+ Partials 13 9 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
in pylint v3.0.0, there is pylint-dev/pylint#8404, that breaks the current implementation of: - ClassAttrLoader - FixtureChecker This fix is an attempt of supporting both pylint v2 and v3
@stdedos , sorry if I overstepped with my last commit. I did it as I was a little confused by the non-deterministic state of the dependencies (specially pylint, where the CI was using v3 and my local vas using v2). let me know if I should place it in another PR |
not needed anymore now that we require >=v2
Fix `pylint` configuration for v3 https://pylint.pycqa.org/en/latest/whatsnew/3/3.0/index.html#changes-requiring-user-actions Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Uuum, definitely some changes need to be rationalized to be merged in this PR 😅 I'll try to review quickly tonight. |
Yeah, I have "quite a few" questions wrt 87baf06. Please force-push revert it, so we can merge this. OTOH, thank you very much for showing this: It was a mash-up of TILs for me 🙃 |
Ok, done. I will re-submit the dependency management part in a later PR, let's just keep in mind that some differences might show up in between local and CI depending of the dependencies version, specially pylint v2/v3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 😄
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
* Support pylint v3 and drop v1 (#27) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
in pylint v3.0.0, there is pylint-dev/pylint#8404, that breaks the current implementation of:
This fix is an attempt of supporting both pylint v2 and v3.
Other chances:
Fixes #12