-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# pylint: … line comments do not play well with other code analyzers (they have to appear at the end) #2485
Comments
Yes, this is 💩 . We should definitely fix it. Another separate idea is that we should add support for |
Should be fixed now. Please give it a go and let me know if it works for you! |
This is the solution for [pylint-dev#2297](pylint-dev#2297), [pylint-dev#2470](pylint-dev#2470), and [pylint-dev#2485](pylint-dev#2485).
This is the solution for [pylint-dev#2297](pylint-dev#2297), [pylint-dev#2470](pylint-dev#2470), and [pylint-dev#2485](pylint-dev#2485).
This is the solution for [pylint-dev#2297](pylint-dev#2297), [pylint-dev#2470](pylint-dev#2470), and [pylint-dev#2485](pylint-dev#2485).
This is the solution for [pylint-dev#2297](pylint-dev#2297), [pylint-dev#2470](pylint-dev#2470), and [pylint-dev#2485](pylint-dev#2485).
Added entry for the solution for [pylint-dev#2297](pylint-dev#2297), [pylint-dev#2470](pylint-dev#2470), and [pylint-dev#2485](pylint-dev#2485).
@PCManticore , thank you for taking the time to try to fix this issue. I had reported this issue as well - #2470 . However, I tried the code here on GitHub, but there is no change in behavior. For instance, I have a line like this Although, I submitted a pull request that has the solution for #2297, #2470, and #2485. The solution: Pull Request 2537 |
@DevynCJohnson Thanks but I don't think your PR actually changes anything for your linked issues. As mentioned in #2537 (comment), the current |
Consider someone who uses Mypy notations, pyflakes, pylint, and bandit. This will confuse pylint:
… # type: … # noqa: E501 # pylint: disable=line-too-long # nosec
Pylint will give you the warning:
pylint: Bad option value 'line-too-long # nosec' ("bad-option-value")
. Pylint requires the line be written as follows (with the# pylint
comment at the end):… # type: … # noqa: E501 # nosec # pylint: disable=line-too-long
See also #199 and #2297.
The text was updated successfully, but these errors were encountered: