Suggest to iterate thorough dict items() instead of keys

[EugeneZelenko]

It'll be great to recognize loops that could iterate through items() instead of keys.

Example of problematic code pattern:

for d in a_dict:
    print(d, a_dict[d])

[PCManticore]

Thanks for the report!

[ursmaheshj]

for d in a_dict.values():
print(d)

[yushao2]

Opened PR #4445 , please take a look :)

There might be some issues as it is my first time contributing and I'm still not 100% sure if I'm doing it right

[cdce8p]

for d in a_dict.values():
    print(d)

@ursmaheshj Could you explain what you mean, I'm not quite following? At least I can't think of any case where I would use dict.values and later access the keys from it. Just to get them, I would need to iterate over all items again and even then can't be sure that it's the right key.

[ursmaheshj]

@ursmaheshj Could you explain what you mean, I'm not quite following? At least I can't think of any case where I would use dict.values and later access the keys from it. Just to get them, I would need to iterate over all items again and even then can't be sure that it's the right key.

@cdce8p Yeah got it, i think i just misunderstood the issue.

[craiga]

Thanks so much for your work here!

An hour ago I was going to log a bug against this change, but it turned out that my code contained an insidious little bug where it wasn't iterating over a data structure as it should've been. Thanks again!