do not report too-few-public-methods for attr.s, attr.dataclass, typing.NamedTuple and similar.

[graingert]

do not report too-few-public-methods for attr.s, attr.dataclass, typing.NamedTuple and similar.

example:

import attr

@attr.dataclass(frozen=True)  # pylint-ignore: too-few-public-methods
class Foo:
    ham: str
    spam: str

@uriva As mentioned by @matkoniecz in most cases the check makes sense. If your class has a single method on it, it's probably a function in disguise. You can also configure the number of public methods with min-public-methods. But there are a couple of classes for which we should not report this, as it makes perfect sense to not have too many methods or no methods at all. This includes attrs, dataclasses, typing.NamedTuple and similar.

Originally posted by @PCManticore in #2710 (comment)

[uriva]

I'm not sure why this reopened, I am no longer using pylint (moved to flake8) so no interest in this anymore.
Thanks

[matkoniecz]

I am also not sure why you copied the comment outright pinging all involved rather than posting only relevant part.

Posting "I'm going to close this issue" while opening an issue is bizarre.

Also: give a code sample wrongly reported as mistake.

[graingert]

@matkoniecz comment now quoted, code example added

[graingert]

I am also not sure why you copied the comment outright pinging all involved rather than posting only relevant part.

I just hit the "reference in new issue button"

[Pierre-Sassoulas]

This message is probably going to be disabled by default because there is a lot of example of place where it makes sense to have few public method (Django Meta class, inheritance of class that implements a run() function etc.) See #3512 . If you think this is useful and want to use it, but with a whitelist of class that can have few public method, I don't think there is an easy way to do that right now, but I think this is doable.

[earonesty]

Configurable suppressions for classes would be generally useful:

Simple config override in .pylintrc for classes that:

# [CLASSRULES.<CUSTOM_NAME>]
# metaclass_match=<metaclass_regex>
# parent_match=<parent_regex>
# disable=list,of,disables

Would solve a lot of these issues.

[Pierre-Sassoulas]

Also true for exceptions see : #4464

[wnoise]

Also true for anything inheriting from typing.Protocol.

[graingert]

@Pierre-Sassoulas why was this unpinned?

[graingert]

this should also not report: too-many-instance-attributes for attr.s

[Pierre-Sassoulas]

I unpinned it because there was more pressing issues to advertise first (ranked according to number of thumbsup or heart reactions), it does not mean that I would not review a fix for this ;)

[g1itch]

What about context managers? May pylint detect them by __enter__() and __exit__() methods defined?

[davebirch]

If this is still for consideration, attrs now support an @define decorator, as well as @attr.s.