[Astroid 2.5] astroid.exceptions.DuplicateBasesError: Duplicates found in MROs (OrderedSet) #4093

Toilal · 2021-02-15T21:28:35Z

Steps to reproduce

git clone https://github.com/inetum-orleans/docker-devbox-ddb
cd docker-devbox-ddb
pylint ddb
💥

Current behavior

Pylint crash with the following stack

Traceback (most recent call last):
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/decorators.py", line 34, in cached
    return cache[func]
KeyError: <bound method ClassDef.slots of <ClassDef.OrderedSet l.55 at 0x7f75735663d0>>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/toilal/.pyenv/versions/3.8.7-ddb/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/__init__.py", line 22, in run_pylint
    PylintRun(sys.argv[1:])
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/lint/run.py", line 349, in __init__
    linter.check(args)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/lint/pylinter.py", line 862, in check
    self._check_files(
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/lint/pylinter.py", line 896, in _check_files
    self._check_file(get_ast, check_astroid_module, name, filepath, modname)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/lint/pylinter.py", line 922, in _check_file
    check_astroid_module(ast_node)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/lint/pylinter.py", line 1054, in check_astroid_module
    retval = self._check_astroid_module(
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/lint/pylinter.py", line 1099, in _check_astroid_module
    walker.walk(ast_node)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/utils/ast_walker.py", line 75, in walk
    self.walk(child)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/utils/ast_walker.py", line 72, in walk
    callback(astroid)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/pylint/checkers/variables.py", line 1203, in visit_importfrom
    module = node.do_import_module(name_parts[0])
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/mixins.py", line 99, in do_import_module
    return mymodule.import_module(
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/scoped_nodes.py", line 646, in import_module
    return MANAGER.ast_from_module_name(absmodname)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/manager.py", line 191, in ast_from_module_name
    return self.ast_from_file(found_spec.location, modname, fallback=False)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/manager.py", line 100, in ast_from_file
    return AstroidBuilder(self).file_build(filepath, modname)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/builder.py", line 139, in file_build
    return self._post_build(module, encoding)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/builder.py", line 159, in _post_build
    self.delayed_assattr(delayed)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/builder.py", line 235, in delayed_assattr
    if not _can_assign_attr(inferred, node.attrname):
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/builder.py", line 60, in _can_assign_attr
    slots = node.slots()
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/decorators.py", line 36, in cached
    cache[func] = result = func(*args, **kwargs)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/scoped_nodes.py", line 2838, in slots
    slots = list(grouped_slots())
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/scoped_nodes.py", line 2823, in grouped_slots
    for cls in self.mro()[:-1]:
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/scoped_nodes.py", line 2909, in mro
    return self._compute_mro(context=context)
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/scoped_nodes.py", line 2898, in _compute_mro
    unmerged_mro = list(clean_duplicates_mro(unmerged_mro, self, context))
  File "/home/toilal/.pyenv/versions/3.8.7/envs/3.8.7-ddb/lib/python3.8/site-packages/astroid/scoped_nodes.py", line 110, in clean_duplicates_mro
    raise exceptions.DuplicateBasesError(
astroid.exceptions.DuplicateBasesError: Duplicates found in MROs (OrderedSet), (_GenericAlias, _Final, object), (_GenericAlias, _Final, object), (_GenericAlias, _GenericAlias) for <ClassDef.OrderedSet l.55 at 0x7f75735663d0>.

Expected behavior

It should lint as usual.

pylint --version output

pylint 2.6.0
astroid 2.5
Python 3.8.7 (default, Jan 19 2021, 12:16:28) 
[GCC 9.3.0]

Problem occurs after upgrading astroid to 2.5. pip install "astroid<2.5" to workaround the issue.

The text was updated successfully, but these errors were encountered:

Pierre-Sassoulas · 2021-02-15T22:33:49Z

@hippo91 maybe pylint 2.6.0 needs to specify astroid < 2.5 ? If that's the case we could release 2.6.1with just a dependency change.

cdce8p · 2021-02-15T23:43:10Z

Hmm, I can't seem to reproduce it. I wanted to check if the error also occurs with the current pylint master branch and astroid 2.5, but it even ran without issues the first time. Here is what I did

git clone git@github.com:inetum-orleans/docker-devbox-ddb.git
# develop branch, last commit: bcf04b523482de438742e51d47198464d00f0553

cd docker-devbox-ddb.git
python3.8 -m venv venv
source venv/bin/activate
pip install pylint
pylint ddb

pylint 2.6.0
astroid 2.5
Python 3.8.7 (v3.8.7:6503f05dd5, Dec 21 2020, 12:45:15) 
[Clang 6.0 (clang-600.0.57)]
--
macOS Catalina (10.15.7)

--

@Toilal Could you provide more details (operating system, the exact commit you tested, any other useful information)? Would be great if you could also try the current master branch.

# In a new environment, run
pip install -U git+git://github.com/PyCQA/pylint.git@e48946f0b4bd385fcd93b6ef920d092f0d8d7424

If that works, we would know that the pining the astroid version as @Pierre-Sassoulas suggested would be enough to fix it.

Toilal · 2021-02-16T06:06:09Z

Ubuntu 20.04
python 3.8.7 installed with pyenv
develop branch of https://github.com/inetum-orleans/docker-devbox-ddb
edit setup.py to remove <2.5 constraint on astroid (current workaround)
pip install -e .[dev]
pylint ddb

I have tried current master branch, problem still occurs.

Toilal · 2021-02-16T07:15:54Z

Also, it works properly with pylint master and astroid<2.5

Pierre-Sassoulas · 2021-02-16T07:35:03Z

Should be fixed in 2.6.1, I just released. We had astroid>=2.4.0,<=2.5, it should have been astroid>=2.4.0,<2.5.

Pierre-Sassoulas · 2021-02-16T07:37:01Z

Thank you @Toilal for reporting the issue so fast!

fdosani · 2021-02-19T01:51:02Z

Hi there, Sorry to bring to life a closed issue here but felt it was better than opening a new issue. I sort of stumbled here looking through the commits and I'm getting the following error RecursionError: maximum recursion depth exceeded while calling a Python object. It seems due to the change which sets astroid < 2.5. If I force my env to bump up to 2.5 it works fine without issue. Happy to open an new issue for this but though I'd checkin and see if astroid wasn't going to be bumped back in the next release?

hippo91 · 2021-02-21T09:38:40Z

@fdosani thanks for the report.
The future pylint version (coming soon) will use astroid 2.5, thus your problem will be fixed.
If you wan, you can try astroid 2.5 with the current pylint master.

hippo91 · 2021-02-21T10:04:51Z

@tollal thanks for the report. I can reproduce it.
I found the faulty commit (7f1d5134d89aab9b3e49030676637debfd731dbb). I opened a dedicated issue in astroid : pylint-dev/astroid#905

Toilal · 2021-02-23T23:57:16Z

This stills occurs in pylint 2.7. I currently have to add those constraints as a workaround.

    "astroid<2.5",
    "pylint<2.7",

cdce8p · 2021-02-28T23:19:15Z

@Toilal Pylint 2.7.2 has just been released. That should have fixed the issue. Just to be sure, can you test if everything works?

Toilal · 2021-03-01T20:35:25Z

It works, thanks.

Pierre-Sassoulas added Crash 💥 A bug that makes pylint crash Regression labels Feb 15, 2021

Pierre-Sassoulas mentioned this issue Feb 15, 2021

New release for Python 3.9? #4055

Closed

Pierre-Sassoulas added a commit that referenced this issue Feb 16, 2021

Fix #4093 by setting astroid dependencie as < 2.5

5354c42

Pierre-Sassoulas added this to the 2.6.1 milestone Feb 16, 2021

Pierre-Sassoulas self-assigned this Feb 16, 2021

Pierre-Sassoulas closed this as completed Feb 16, 2021

Pierre-Sassoulas mentioned this issue Feb 16, 2021

Pylint milestones for 2.5.4 were not all fixed before the release of 2.6.0 #3831

Closed

Pierre-Sassoulas added a commit that referenced this issue Feb 16, 2021

Fix #4093 by setting astroid dependencie as < 2.5

c1d58e7

maramon mentioned this issue Feb 18, 2021

python/python3-astroid: Updated for version 2.5. SlackBuildsOrg/slackbuilds#708

Closed

hippo91 mentioned this issue Feb 21, 2021

Duplicates found in MROs (OrderedSet) pylint-dev/astroid#905

Closed

This was referenced Feb 23, 2021

pylint with astroid 2.5 raises an exception when checking aiohttp or any library that depends on aiohttp #4131

Closed

Partially revert astroid install requirement #4130

Closed

Pierre-Sassoulas reopened this Feb 24, 2021

Pierre-Sassoulas modified the milestones: 2.6.1, 2.7.2 Feb 24, 2021

Pierre-Sassoulas added the Blocker 🙅 Blocks the next release label Feb 24, 2021

cdce8p mentioned this issue Feb 24, 2021

Pylint fails to run, exits with a PicklingError #4145

Closed

pronovic mentioned this issue Feb 27, 2021

Run test suite with python-testdox for more verbose output pronovic/apologies-server#24

Merged

hippo91 mentioned this issue Feb 27, 2021

Bug 905 pylint-dev/astroid#913

Closed

2 tasks

cdce8p mentioned this issue Feb 28, 2021

Fix typing alias pylint-dev/astroid#916

Merged

2 tasks

Pierre-Sassoulas closed this as completed in pylint-dev/astroid#916 Feb 28, 2021

dependabot bot mentioned this issue Mar 14, 2021

Bump astroid from 2.4.2 to 2.5.1 PennyDreadfulMTG/Penny-Dreadful-Tools#8447

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Astroid 2.5] astroid.exceptions.DuplicateBasesError: Duplicates found in MROs (OrderedSet) #4093

[Astroid 2.5] astroid.exceptions.DuplicateBasesError: Duplicates found in MROs (OrderedSet) #4093

Toilal commented Feb 15, 2021

Pierre-Sassoulas commented Feb 15, 2021

cdce8p commented Feb 15, 2021

Toilal commented Feb 16, 2021 •

edited

Loading

Toilal commented Feb 16, 2021

Pierre-Sassoulas commented Feb 16, 2021

Pierre-Sassoulas commented Feb 16, 2021

fdosani commented Feb 19, 2021 •

edited

Loading

hippo91 commented Feb 21, 2021

hippo91 commented Feb 21, 2021

Toilal commented Feb 23, 2021

cdce8p commented Feb 28, 2021

Toilal commented Mar 1, 2021

[Astroid 2.5] astroid.exceptions.DuplicateBasesError: Duplicates found in MROs (OrderedSet) #4093

[Astroid 2.5] astroid.exceptions.DuplicateBasesError: Duplicates found in MROs (OrderedSet) #4093

Comments

Toilal commented Feb 15, 2021

Steps to reproduce

Current behavior

Expected behavior

pylint --version output

Pierre-Sassoulas commented Feb 15, 2021

cdce8p commented Feb 15, 2021

Toilal commented Feb 16, 2021 • edited Loading

Toilal commented Feb 16, 2021

Pierre-Sassoulas commented Feb 16, 2021

Pierre-Sassoulas commented Feb 16, 2021

fdosani commented Feb 19, 2021 • edited Loading

hippo91 commented Feb 21, 2021

hippo91 commented Feb 21, 2021

Toilal commented Feb 23, 2021

cdce8p commented Feb 28, 2021

Toilal commented Mar 1, 2021

Toilal commented Feb 16, 2021 •

edited

Loading

fdosani commented Feb 19, 2021 •

edited

Loading