Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install on the CPython 3.11 (broken indirect wrapt deps) #5919

Closed
skirpichev opened this issue Mar 15, 2022 · 7 comments
Closed

Can't install on the CPython 3.11 (broken indirect wrapt deps) #5919

skirpichev opened this issue Mar 15, 2022 · 7 comments
Milestone

Comments

@skirpichev
Copy link
Contributor

Bug description

see e.g. this build. Installation crashed with

...
        File "/tmp/pip-install-hn0tio4e/wrapt_c7c8c7364f77442a93dd53644b6abd58/src/wrapt/__init__.py", line 10, in <module>
          from .decorators import (adapter_factory, AdapterFactory, decorator,
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-install-hn0tio4e/wrapt_c7c8c7364f77442a93dd53644b6abd58/src/wrapt/decorators.py", line 34, in <module>
          from inspect import ismethod, isclass, formatargspec
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      ImportError: cannot import name 'formatargspec' from 'inspect' (/opt/hostedtoolcache/Python/3.11.0-alpha.5/x64/lib/python3.11/inspect.py)
      [end of output]

This should be fixed in the v1.14 of the wrapt.

Configuration

No response

Command used

Nothing (not installed)

Pylint output

Nothing

Expected behavior

Installation succesful.

Pylint version

Python 3.11, pylint v2.12.2

OS / Environment

No response

Additional dependencies

No response

@skirpichev skirpichev added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Mar 15, 2022
skirpichev added a commit to skirpichev/diofant that referenced this issue Mar 15, 2022
This reverts commit 442f6a2.

Reverted due to astroid deps on wrapt < 1.14 (pylint-dev/pylint#5919)
@Pierre-Sassoulas Pierre-Sassoulas added python 3.11 and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Mar 15, 2022
@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Mar 15, 2022

Thank you for opening the issue. We're not supporting (i.e. testing) python 3.11 yet, we're going to do that when a beta version is released here: https://github.com/actions/python-versions/releases, see #5127

@skirpichev
Copy link
Contributor Author

This should be fixed with astroid 2.11.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Mar 15, 2022
@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Mar 15, 2022

OK, then it's already fixed in the development branch. Could you check if pip install git+git://github.com/PyCQA/pylint.git@main#egg=pylint -U fix the problem and close the issue if it does ?

We're trying to release 2.13.0 asap.

@DanielNoord
Copy link
Collaborator

I'm checking CI on 3.11 as we speak on DanielNoord#101.

I'll update if we can turn it on 👍

@DanielNoord
Copy link
Collaborator

Seems like tomllib has been accepted and merged python/cpython#31498 but not yet released to any of the images available on Github.

Next release is expected on 2022-04-05 so we'll need to wait a bit.

@DanielNoord DanielNoord modified the milestones: 2.13.0, 2.14.0 Mar 15, 2022
@DanielNoord DanielNoord added the Blocked 🚧 Blocked by a particular issue label Mar 15, 2022
@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Mar 15, 2022

I opened #5920 for the issue with github actions, so we can close this issue if the problem with wrapt under python 3.11 was fixed in astroid 2.11.0 and the futur pylint 2.13.0.

@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Mar 15, 2022
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.14.0, 2.13.0 Mar 15, 2022
@skirpichev
Copy link
Contributor Author

OK, then it's already fixed in the development branch

DanielNoord#101 was failing on 3.11, so - not yet. However, astroid deps is fixed in dev, yes. Probably, this might be closed.

KevinGDialpad added a commit to talkiq/confluence-wiki-sync that referenced this issue Nov 5, 2022
CircleCI started running tests on Python 3.11, and we ran into pylint-dev/pylint#5919
TylerJang27 added a commit to trunk-io/plugins that referenced this issue Dec 21, 2023
This download is cross-platform compatible. I also tested setting KGV on
the newer version to spot-check: note that our current setup/KGV of
`pylint` is incompatible with `python@3.11.x` (per
pylint-dev/pylint#5919 is fixed in newer
versions of pylint)
pat-trunk-io pushed a commit to trunk-io/plugins that referenced this issue Jan 22, 2024
This download is cross-platform compatible. I also tested setting KGV on
the newer version to spot-check: note that our current setup/KGV of
`pylint` is incompatible with `python@3.11.x` (per
pylint-dev/pylint#5919 is fixed in newer
versions of pylint)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants