Try to fix make.bat for Windows 11 #10072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10072 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18959 18959
=======================================
Hits 18163 18163
Misses 796 796 |
DanielNoord
reviewed
Nov 5, 2024
| echo. Please use `make ^<target^>` where ^<target^> is one of: | ||
| echo. | ||
| echo. install-dependencies to install required documentation dependencies | ||
| echo. html to make standalone HTML files |
There was a problem hiding this comment.
I think we should only document the options we actually support
There was a problem hiding this comment.
Is all the other stuff even used somewhere? How about removing it completly?
There was a problem hiding this comment.
We removed it from the other make file as well!
Pierre-Sassoulas
added
Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow Up to this: 10064
I noticed that my changes to make.bat do not work for my Windows 11 Laptop. So I fixed it in here