Skip to content

Conversation

@aaronliu0130
Copy link
Contributor

Upstream also undeprecated it in December (python/cpython#126227). Feels a bit weird, and sorry for not noticing this earlier. Hopefully I got the news fragment thing right. I wonder if we should mention that these modules were undeprecated?

Type of Changes

Type
🐛 Bug fix

Description

Refs #10211

@aaronliu0130
Copy link
Contributor Author

Definitely should've tested this. On it.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Pierre-Sassoulas Pierre-Sassoulas added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/4.0.x labels Feb 1, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.5 milestone Feb 1, 2025
@codecov
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.84%. Comparing base (47579c8) to head (bb28bf1).
⚠️ Report is 340 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10215   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         175      175           
  Lines       19056    19056           
=======================================
  Hits        18264    18264           
  Misses        792      792           
Files with missing lines Coverage Δ
pylint/checkers/imports.py 94.86% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

🤖 Effect of this PR on checked open source code: 🤖

Effect on coverage:
The following messages are now emitted:

  1. useless-suppression:
    Useless suppression of 'deprecated-module'
    https://github.com/nedbat/coveragepy/blob/fcdce1deb2f182dc5a34fdc6d91b50033ed2badb/coverage/cmdline.py#L9

The following messages are no longer emitted:

  1. suppressed-message:
    Suppressed 'deprecated-module' (from line 9)
    https://github.com/nedbat/coveragepy/blob/fcdce1deb2f182dc5a34fdc6d91b50033ed2badb/coverage/cmdline.py#L9

This comment was generated for commit bb28bf1

@jacobtylerwalls jacobtylerwalls merged commit acf7705 into pylint-dev:main Feb 2, 2025
44 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 2, 2025
(cherry picked from commit acf7705)
@jacobtylerwalls
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants