Skip to content

Fix unused-variable false positive with __all__ or __future__.annotations #10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

Fix unused-variable false positive with __all__ or __future__.annotations #10643

merged 2 commits into from
Oct 13, 2025

Conversation

@mbyrnepr2
Copy link
Member

@mbyrnepr2 mbyrnepr2 commented Oct 12, 2025 •
edited
Loading

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Exclude __all__ and __future__.annotations from unused-variable.

Closes #10019

@mbyrnepr2 mbyrnepr2 added this to the 4.1.0 milestone Oct 12, 2025
@mbyrnepr2 mbyrnepr2 added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Oct 12, 2025
@codecov
Copy link

codecov bot commented Oct 12, 2025 •
edited
Loading

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 95.96%. Comparing base (3de1fbc) to head (34ce09c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10643   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         176      176           
  Lines       19502    19506    +4     
=======================================
+ Hits        18715    18719    +4     
  Misses        787      787
Files with missing lines Coverage Ξ”
pylint/checkers/variables.py 97.15% <100.00%> (+<0.01%) ⬆️
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 4.1.0, 4.0.1 Oct 12, 2025
Pierre-Sassoulas
Pierre-Sassoulas previously approved these changes Oct 12, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@github-actions

This comment has been minimized.

Sign in to view
@mbyrnepr2 @Pierre-Sassoulas
Update doc/whatsnew/fragments/10019.false_positive
34ce09c 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2025

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 34ce09c

@Pierre-Sassoulas Pierre-Sassoulas merged commit bbbdb9d into pylint-dev:main Oct 13, 2025
44 checks passed
pylint-backport bot pushed a commit that referenced this pull request Oct 13, 2025
@mbyrnepr2 @pylint-backport
Fix unused-variable false positive with __all__ or `__future__.an…
00ebd64 
…notations` (#10643)

Closes #10019

(cherry picked from commit bbbdb9d)
@pylint-backport pylint-backport bot mentioned this pull request Oct 13, 2025
Merged
cdce8p pushed a commit that referenced this pull request Oct 13, 2025
@pylint-backport @mbyrnepr2
[Backport maintenance/4.0.x] Fix unused-variable false positive wit…
e60b80e 
…h `__all__` or `__future__.annotations` (#10653)

Fix `unused-variable` false positive with `__all__` or `__future__.annotations` (#10643)

(cherry picked from commit bbbdb9d)

Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees

No one assigned

Labels

backport maintenance/4.0.x False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

Don't consider __future__ imports and __all__ unused

3 participants

@mbyrnepr2 @Pierre-Sassoulas @cdce8p