Fix false positive unused-variable in lambda default arguments #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NameConsumer to_consume frame needed to be backed out by one so that for lambda bound default argument variables (closure) could consume the name in a higher scope (just like function default arguments) Close pylint-dev#1921 Close pylint-dev#1552 Close pylint-dev#1099 Close pylint-dev#210
|
Amazing fix as well! Keep up the good work! I enjoy every PR that closes a couple of issues all at once. |
This was referenced Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NameConsumer to_consume frame needed to be backed out by one so that
for lambda bound default argument variables (closure) could consume the
name in a higher scope (just like function default arguments)
Close #1921
Close #1552
Close #1099
Close #210