Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account __class_getitem__ from PEP 560 #2702

Merged
merged 2 commits into from
Feb 4, 2019

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Jan 20, 2019

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Take into account __class_getitem__ from PEP 560 and fixes some false positives for no-self-argument and unsubscriptable-object.

Type of Changes

Type
🐛 Bug fix

Related Issue

Closes #2416

@PCManticore
Copy link
Contributor

Thanks for the PR, I will take a look this weekend!

@PCManticore PCManticore merged commit 03b4d03 into pylint-dev:master Feb 4, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 89.597% when pulling da010b5 on pcorpet:class-getitem into c2af5c7 on PyCQA:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 89.597% when pulling da010b5 on pcorpet:class-getitem into c2af5c7 on PyCQA:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 89.597% when pulling da010b5 on pcorpet:class-getitem into c2af5c7 on PyCQA:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 89.597% when pulling da010b5 on pcorpet:class-getitem into c2af5c7 on PyCQA:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsubscriptable-object error reported incorrectly
3 participants