Fix score option for JSON export

[Pierre-Sassoulas]

Steps

• Add a ChangeLog entry describing what your PR does.
• If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.

Description

This fix #3504, but I wonder... It looks like the fabled bug that will break countless integration by being fixed. --score=y is the default setting, and JSON is probably a prime candidate for automation. Is it reasonable to fix it and ask everyone to change their option to -s n? I'm pretty sure no one read the pylint's changelog and even if they do we can't know how many poeple have a working continuous integration that iwll be broken by this.

Type of Changes

	Type
✓	🐛 Bug fix

Related Issue

Closes #3504

[coveralls]

Coverage increased (+0.005%) to 91.48% when pulling f6b5a72 on Pierre-Sassoulas:fix-3504-json-reporter into 6721cd1 on PyCQA:master.

[Pierre-Sassoulas]

There might be a better way, but understanding the way the VNode works and how one can finally get the message encapsulated in ten layers of linked list and visitor pattern does not seem worth it.

[PCManticore]

Uf, this is tough. I don't think we should fix it as the JSON integration is most likely at the basis of multiple CI tools for consuming and displaying pylint results (e.g. tools like Codacy or custom Jenkins integrations come to mind).

Seems like a good candidate for a potential 3.0 release though, but for now we should keep it as is.

[angristan]

This looks very unhandy to consume programmatically:

[
    {
        "type": "convention",
        "module": "fib",
        "obj": "",
        "line": 1,
        "column": 0,
        "path": "fib.py",
        "symbol": "missing-module-docstring",
        "message": "Missing module docstring",
        "message-id": "C0114"
    },
    {
        "score": "Your code has been rated at 3.33/10"
    }
]

Wouldn't something like this be better?

{
    "score": 0.333,
    "violations": [
        {
            "type": "convention",
            "module": "fib",
            "obj": "",
            "line": 1,
            "column": 0,
            "path": "fib.py",
            "symbol": "missing-module-docstring",
            "message": "Missing module docstring",
            "message-id": "C0114"
        }
    ]
}

[Pierre-Sassoulas]

You're right. And as 3.0 is an alpha version, everything can change right now :) Could you open an issue for this, please ?

[angristan]

Sure 👍