Skip to content

Conversation

@hippo91
Copy link
Contributor

@hippo91 hippo91 commented Aug 17, 2020

Steps

  • [ x ] Add a ChangeLog entry describing what your PR does.
  • [ x ] If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • [ x ] Write a good description on what the PR does.

Description

This PR adds the astroid.Dict class in the list of types that have to be compared in order to determine if a method in a derived class has the same default keyword argument than the equivalent in the base class.

Type of Changes

Type
🐛 Bug fix

Related Issue

Closes #3773

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 90.693% when pulling c924b9b on hippo91:bug_pylint_3773 into 707fc46 on PyCQA:master.

@coveralls
Copy link

coveralls commented Aug 17, 2020

Coverage Status

Coverage remained the same at 90.726% when pulling 64bebf3 on hippo91:bug_pylint_3773 into 2261844 on PyCQA:master.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense ! I like that the fix is just that one line, and everything around it explains pretty well why we need to add that line.

@hippo91
Copy link
Contributor Author

hippo91 commented Sep 3, 2020

Makes sense ! I like that the fix is just that one line, and everything around it explains pretty well why we need to add that line.

Thanks for reviewing this @Pierre-Sassoulas !

@hippo91 hippo91 merged commit 3e7e3ca into pylint-dev:master Sep 3, 2020
@hippo91 hippo91 deleted the bug_pylint_3773 branch September 3, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive with useless-super-delegation for keyword args with dict defaults

3 participants