Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint multiprocessing pool shutdown #3869

Merged
merged 1 commit into from
Oct 31, 2020
Merged

lint multiprocessing pool shutdown #3869

merged 1 commit into from
Oct 31, 2020

Conversation

manderj
Copy link
Contributor

@manderj manderj commented Oct 1, 2020 •
edited
Loading

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Shutdown multiprocessing pool properly (base on pytest-cov recommandation here);fixing the triggered warnings from parallel runs of pytest plugins (pytest-cov and pytest-pylint in this case (see issue #3779))

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Closes #3779

@coveralls
Copy link

coveralls commented Oct 2, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 90.826% when pulling 136ab0f on manderj:pytest_pylint_parallel_runs_warnings into 34d6fcb on PyCQA:master.

@martinpitt martinpitt mentioned this pull request Oct 13, 2020
Merged
@manderj manderj closed this Oct 16, 2020
@manderj manderj deleted the pytest_pylint_parallel_runs_warnings branch October 16, 2020 07:24
@manderj manderj restored the pytest_pylint_parallel_runs_warnings branch October 16, 2020 07:29
@manderj manderj reopened this Oct 16, 2020
hippo91
hippo91 approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@hippo91 hippo91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manderj thanks for this clear PR!
Just left a couple of comments.
Can you also add an entry in doc/whatsnew/2.6.rst please?

ChangeLog Show resolved Hide resolved
CONTRIBUTORS.txt Outdated Show resolved Hide resolved
@hippo91 hippo91 self-assigned this Oct 30, 2020
@manderj
Copy link
Contributor Author

manderj commented Oct 30, 2020

👋 @hippo91, thanks for the review !
I did the changes you requested, let me know if it need other changes 🙂

@manderj manderj requested a review from hippo91 October 31, 2020 09:22
hippo91
hippo91 approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@hippo91 hippo91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manderj !

@hippo91 hippo91 merged commit 70cdb9d into pylint-dev:master Oct 31, 2020
@hippo91 hippo91 mentioned this pull request Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hippo91 hippo91 hippo91 approved these changes

Assignees

@hippo91 hippo91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement proper multiprocessing shutdown
3 participants
@manderj @coveralls @hippo91