Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require astroid 2.5.7 #4523

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Description

Upgrade astroid so we get the latest fixes.

Related Issue

#4471
#4473
#4428
#4348
#4325

@Pierre-Sassoulas Pierre-Sassoulas added the Astroid Related to astroid label May 29, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.8.3 milestone May 29, 2021
@cdce8p
Copy link
Member

cdce8p commented May 29, 2021

The tests require #4325 and #4428 to be merged. I would suggest merging this one and the two mention even with test not passing initially.

@coveralls
Copy link

coveralls commented May 29, 2021

Coverage Status

Coverage decreased (-0.01%) to 91.832% when pulling 0579186 on Pierre-Sassoulas:use-astroid-2.5.7 into 4f8ab69 on PyCQA:master.

@Pierre-Sassoulas
Copy link
Member Author

Ha, I saw your message too late. Well better late than never.

@cdce8p
Copy link
Member

cdce8p commented May 30, 2021

FYI: I've updated all related MRs and merged them after the tests passed.

@Pierre-Sassoulas
Copy link
Member Author

Thank you, great job ! Look like pylint got slower though, I feel we need to check #4524 before releasing 2.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Astroid Related to astroid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants