Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various deprecated functions/methods for python 3.10, 3.7, 3.6 and 3.3 #4620

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

matusvalo
Copy link
Collaborator

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Added various deprecated functions/methods for python 3.10, 3.7, 3.6 and 3.3.

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

Requires merging #4619.

@matusvalo matusvalo marked this pull request as draft June 27, 2021 22:09
@coveralls
Copy link

coveralls commented Jun 27, 2021

Coverage Status

Coverage remained the same at 92.041% when pulling a5d7e18 on matusvalo:stdlib_improvements into eeb6eea on PyCQA:master.

@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label Jun 28, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.9.0 milestone Jun 28, 2021
@Pierre-Sassoulas Pierre-Sassoulas marked this pull request as ready for review June 29, 2021 17:14
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I couldn't find some of those, but I guess they are fine. If not we will probably know soon after the release ;)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked sqlite3.OptimizedUnicode (it's really deprecated), the other functions are merged based on trust 😄 Thank you @matusvalo 👍

@Pierre-Sassoulas Pierre-Sassoulas merged commit 31afab2 into pylint-dev:master Jun 29, 2021
@matusvalo matusvalo deleted the stdlib_improvements branch June 29, 2021 19:41
@matusvalo
Copy link
Collaborator Author

All deprecations are collected based on What's new documentation of Python releases.

@matusvalo matusvalo mentioned this pull request Jun 29, 2021
4 tasks
matusvalo added a commit to matusvalo/pylint that referenced this pull request Jun 29, 2021
@matusvalo
Copy link
Collaborator Author

I did second review of PR and found several issues - they are handled in PR #4628.

In general the issues are not major and there is no need in quick releasing new pylint version - it can wait for next minor release of pylint.

Pierre-Sassoulas pushed a commit that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants