-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added various deprecated functions/methods for python 3.10, 3.7, 3.6 and 3.3 #4620
Added various deprecated functions/methods for python 3.10, 3.7, 3.6 and 3.3 #4620
Conversation
450dcf1
to
a5d7e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I couldn't find some of those, but I guess they are fine. If not we will probably know soon after the release ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked sqlite3.OptimizedUnicode
(it's really deprecated), the other functions are merged based on trust 😄 Thank you @matusvalo 👍
All deprecations are collected based on What's new documentation of Python releases. |
I did second review of PR and found several issues - they are handled in PR #4628. In general the issues are not major and there is no need in quick releasing new pylint version - it can wait for next minor release of pylint. |
Steps
doc/whatsnew/<current release.rst>
.Description
Added various deprecated functions/methods for python 3.10, 3.7, 3.6 and 3.3.
Type of Changes
Related Issue
Requires merging #4619.