Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for json_reporter and sub-classes #5021

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
🔨 Refactoring

Description

Another instalment of breaking up #4954.
Although the number of changed lines is quite high, it is basically adding typing to the same methods in a bunch of different (sub)classes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1243056352

  • 25 of 31 (80.65%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 93.053%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/reporters/collecting_reporter.py 2 3 66.67%
pylint/testutils/reporter_for_tests.py 6 8 75.0%
pylint/reporters/base_reporter.py 5 8 62.5%
Totals Coverage Status
Change from base Build 1242365285: -0.03%
Covered Lines: 13315
Relevant Lines: 14309

💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Sep 16, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.1 milestone Sep 16, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit 6d07d6f into pylint-dev:main Sep 16, 2021
@DanielNoord DanielNoord deleted the typing-json-reporter branch September 16, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants