Add typing to BaseReporter.out
#5023
Conversation
tests/test_self.py
Outdated
| @@ -122,11 +121,11 @@ def _display(self, layout: "Section") -> None: | |||
| pass | |||
|
|
|||
| @property | |||
| def out(self) -> StringIO: | |||
| def out(self) -> TextIO: # type: ignore # Property is not the same as BaseLinter's attr | |||
There was a problem hiding this comment.
@cdce8p You also commented on this in #4954, see #4954 (comment) and #4954 (comment)
However, this still is an issue. mypy maintainers seem to suggest not doing this kind of stuff (see python/mypy#8185). Do we want to refactor (can we?) or is adding the type: ignore enough. For some reason for the one below I needed two comments.
There was a problem hiding this comment.
I've come across python/mypy#8185 in another project already. Was doing something similar 😅 type: ignore would be fine IMO. See also python/mypy#7994 which suggest to use type: ignore to silence the error.
| def out(self) -> TextIO: # type: ignore # Property is not the same as BaseLinter's attr | |
| def out(self) -> TextIO: # type: ignore[override] |
Pull Request Test Coverage Report for Build 1244657760
💛 - Coveralls |
tests/test_self.py
Outdated
| @property # type: ignore # Property is not the same as BaseLinter's attr | ||
| def linter(self) -> PyLinter: # type: ignore |
There was a problem hiding this comment.
type: ignore[override] should only be necessary on the second line.
There was a problem hiding this comment.
I agree, but mypy doesn't. Note that we also don't get a "useless suppression" warning. Might want to report this as a bug to mypy, but both comments are necessary for mypy to pass.
Pierre-Sassoulas
added
the
Maintenance
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
|
Turns out some reporters are initialised while specifically supplying |
Type of Changes
Description
Small changes which are needed for further typing of
pylint/reporters.I ran the test suite and printed out all types of
BaseReporter.out. It was only everio.TextIOwhich also seems fair given what it is doing. However, perhaps somebody with more knowledge of the code base wants to take a look at this.