Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unspecified-encoding for Path.read_text() #5033

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix unspecified-encoding for Path.read_text() #5033

merged 1 commit into from
Sep 17, 2021

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Sep 17, 2021 •
edited
Loading

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #5029
/CC @Pierre-Sassoulas

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas added Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code labels Sep 17, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.2 milestone Sep 17, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1245368302

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.056%
Totals Coverage Status
Change from base Build 1244644384: 0.001%
Covered Lines: 13321
Relevant Lines: 14315
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit 77e5bd7 into pylint-dev:main Sep 17, 2021
@DanielNoord DanielNoord deleted the encoding-fix branch September 17, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

unspecified-encoding when using Path().read_text() without encoding keyword argument
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas