Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and flatten unused-wildcard-import message #5110

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Improve and flatten unused-wildcard-import message #5110

merged 2 commits into from
Oct 4, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ ✨ New feature

Description

Instead of reporting all unused imports, the checker now emits one single message for all unused imports with a stylized string containing all imports.
This closes #3859

@DanielNoord
Improve and flatten unused-wildcard-import message
341719c 
Instead of reporting all unused imports, the checker now emits one
single message for all unused imports with a stylized string containing
all imports.
This closes pylint-dev#3859
@DanielNoord DanielNoord added the Enhancement ✨ Improvement to a component label Oct 3, 2021
@DanielNoord DanielNoord added this to the 2.12.0 milestone Oct 3, 2021
@coveralls
Copy link

coveralls commented Oct 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1301396544

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.114%
Totals Coverage Status
Change from base Build 1298441056: 0.003%
Covered Lines: 13400
Relevant Lines: 14391
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label Oct 3, 2021
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas Sorry for adding another commit after your approval. Just thought I should add some tests to actually test the string concatenation I added.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry :) Very nice change !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 816fcde into pylint-dev:main Oct 4, 2021
@DanielNoord
Copy link
Collaborator Author

I added this to 2.12 and the changelog also reflects this. I'm find with adding this now, but then the changelog will need to be updated!

Pierre-Sassoulas added a commit that referenced this pull request Oct 4, 2021
@Pierre-Sassoulas
Revert "Improve and flatten unused-wildcard-import message (#5110)"
1a6dc62 
This reverts commit 816fcde.
@Pierre-Sassoulas
Copy link
Member

My bad, I merged prematurely. I will fix this when releasing.

@DanielNoord DanielNoord deleted the unused-wildcard-import branch October 4, 2021 15:28
@cdce8p cdce8p modified the milestones: 2.13.0, 2.12.0 Oct 5, 2021
@DanielNoord DanielNoord removed the Blocked 🚧 Blocked by a particular issue label Nov 30, 2021
@stdweird stdweird mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Is there a way to merge info like this(W0614)
4 participants
@DanielNoord @coveralls @Pierre-Sassoulas @cdce8p