Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use qname to compare classdef default param values #5192

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Use qname to compare classdef default param values #5192

merged 1 commit into from
Oct 21, 2021

Conversation

nickpesce
Copy link
Contributor

Followup that was requested in #5157 (review) by @cdce8p. Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1363923351

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.249%
Totals Coverage Status
Change from base Build 1360083361: 0.0%
Covered Lines: 13632
Relevant Lines: 14619
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added Hacktoberfest Maintenance Discussion or action around maintaining pylint or the dev workflow labels Oct 20, 2021
cdce8p
cdce8p approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this @nickpesce

@cdce8p cdce8p added this to the 2.12.0 milestone Oct 21, 2021
@cdce8p cdce8p merged commit 259f7a3 into pylint-dev:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Hacktoberfest Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nickpesce @coveralls @Pierre-Sassoulas @cdce8p