Add enable-all-extensions option
#5315
Conversation
DanielNoord
added
Enhancement ✨
| option = optikcontainer.add_option(*args, **optdict) | ||
| try: | ||
| option = optikcontainer.add_option(*args, **optdict) | ||
| except optparse.OptionConflictError: |
There was a problem hiding this comment.
@Pierre-Sassoulas Are we sure this doesn't create problems?
Without it for some reason we get an error on accept-no-param-docs being a duplicate error. I couldn't figure out why it did this. This solves the issue and passes the tests, but I wonder if this creates other issues..
There was a problem hiding this comment.
Hmm, it's strange, the error that is caught itself did not seem out of place for me, but if it's accept-no-param-docs being a duplicate error then it's an internal pylint error not an optparse error ? We should probably investigate if that's the case
There was a problem hiding this comment.
I found the issue.
It is the extension check_docs. Because of it we are double loading docparams.
It has been deprecated for 5+ years. Perhaps it is time to remove it?
Pull Request Test Coverage Report for Build 1464306898
💛 - Coveralls |
| @@ -489,7 +489,13 @@ def cb_verbose_mode(self, *args, **kwargs): | |||
| def cb_enable_all_extensions(self, option_name: str, value: None) -> None: | |||
| """Callback to load and enable all available extensions""" | |||
| for filename in os.listdir(os.path.dirname(extensions.__file__)): | |||
| if filename.endswith(".py") and not filename.startswith("_"): | |||
| # pylint: disable=fixme | |||
| # TODO: Remove the check for deprecated check_docs after the extension has been removed | |||
There was a problem hiding this comment.
Shall we remove the extension in 2.13? Or do we consider this 3.0 worthy?
There was a problem hiding this comment.
Let's decide later. these todo list issue are very convenient, I'm going to do more of those. #5317 Feel free to edit :)
There was a problem hiding this comment.
You might want to look into Github projects, I find them even more convenient and much harder to lose out of sight as the issues on the front page increase.
doc/whatsnew/<current release.rst>.Type of Changes
Description
@Pierre-Sassoulas 👀
Might as well put it in
2.12.Partial of #5306.