-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reporters to (allow) use of end_line
and end_column
#5372
Merged
Pierre-Sassoulas
merged 17 commits into
pylint-dev:main
from
DanielNoord:column-reporter
Nov 24, 2021
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f395226
Update reporters to (allow) use end_line and end_column
DanielNoord 09bd841
Merge branch 'main' of https://github.com/PyCQA/pylint into column-re…
DanielNoord 837b65f
Update tests and spelling
DanielNoord 9792d04
Apply suggestions from code review
DanielNoord 45e7bd0
Code review
DanielNoord d980fb8
Code review
DanielNoord 1ed7e17
Code review
DanielNoord 35fd523
Fix mistake with regex
DanielNoord 45e0033
Move the overwrite
DanielNoord 0a6e6d6
Code review
DanielNoord 3c3f141
Add warning
DanielNoord b24dd1c
Apply suggestions from code review
DanielNoord 6ea66c6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a1bdf7c
Update pylint/reporters/text.py
DanielNoord 6e91225
Revert changes to ``JSONReporter``
DanielNoord e280f8c
Merge branch 'column-reporter' of https://github.com/DanielNoord/pyli…
DanielNoord da4932d
Merge branch 'main' into column-reporter
Pierre-Sassoulas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -198,3 +198,10 @@ Other Changes | |
* Fix crash on ``open()`` calls when the ``mode`` argument is not a simple string. | ||
|
||
Partially closes #5321 | ||
|
||
* Add ability to add ``end_line`` and ``end_column`` to the ``--msg-template`` option. | ||
With the standard ``TextReporter`` this will add the line and column number of the | ||
end of a node to the output of Pylint. If these numbers are unknown, they are represented | ||
by an empty string. | ||
|
||
* Add ``end_line`` and ``end_column`` fields to the output of the ``JSONReporter``. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It look like a breaking change that should wait for #4741. We have a 3.0 alpha branch, might be the time to dust it off ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reverted! See #5380 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could also change the default for msg-template in 3.0. Do we want the default to have end line and end column ? This seems like something that is useful in an IDE but not a lot for a text output read by humans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdce8p Argued that we might leave the default output as is because of the potential to break many tools. I think this is a discussion which (if we want to have it anyway) we could leave until we are closer to the release of
3.0
. With this merge everybody that wants to can use this new feature!