Skip to content

Make parallel checker use MessageLocationTuple for Message #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

Make parallel checker use MessageLocationTuple for Message #5381

merged 1 commit into from
Nov 24, 2021

Conversation

@DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Nov 24, 2021

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

No longer trigger our own DeprecationWarning for Message requiring MessageLocationTuple.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Nov 24, 2021
@DanielNoord DanielNoord added this to the 2.12.0 milestone Nov 24, 2021
@coveralls
Copy link

coveralls commented Nov 24, 2021

Pull Request Test Coverage Report for Build 1498393366

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 93.44%
Files with Coverage Reduction New Missed Lines %
pylint/message/message.py 2 86.67%
Totals Coverage Status
Change from base Build 1496292499: -0.01%
Covered Lines: 13930
Relevant Lines: 14908
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surgical precision ! I wanted to do that for a long time myself but did not know where to do the change 😄

@DanielNoord
Copy link
Collaborator Author

DanielNoord commented Nov 24, 2021

Yeah, this was a strange one. The test themselves provided no hint as to where this was being raised.

@DanielNoord DanielNoord merged commit e3a1e35 into pylint-dev:main Nov 24, 2021
@DanielNoord DanielNoord deleted the tests-warning branch November 24, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

Maintenance Discussion or action around maintaining pylint or the dev workflow

Projects

None yet

Milestone

2.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielNoord @coveralls @Pierre-Sassoulas