Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_inside_lambda from utils #5447

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Deprecate is_inside_lambda from utils #5447

merged 5 commits into from
Dec 3, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Follow up to #5331. We might as well use this new util for all similar type of functions

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Nov 30, 2021
@coveralls
Copy link

coveralls commented Nov 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1535603923

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 93.532%
Totals Coverage Status
Change from base Build 1535346807: 0.0009%
Covered Lines: 14027
Relevant Lines: 14997
💛 - Coveralls

@DanielNoord DanielNoord mentioned this pull request Dec 2, 2021
Merged
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.2 milestone Dec 3, 2021
Pierre-Sassoulas
Pierre-Sassoulas requested changes Dec 3, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A non trivial conflict appeared following the merge of the visit_name refactor, and it would also be nice to have a test for the deprecation warning.

pylint/checkers/utils.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.12.2, 2.13.0 Dec 3, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanielNoord DanielNoord merged commit f89a337 into pylint-dev:main Dec 3, 2021
@DanielNoord DanielNoord deleted the typed-ancestor branch December 3, 2021 15:07
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.13.0, 2.12.2 Dec 3, 2021
@cdce8p
Copy link
Member

cdce8p commented Dec 3, 2021

It isn't a huge deal, but technically this PR adds a new DeprecationWarning. Going forward, I think it would make sense to do those changes only for minor releases. I.e. 2.13.0.

Anyway, 2.12.2 is already "special" ;)

@DanielNoord
Copy link
Collaborator Author

Ah sorry, little too trigger happy 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielNoord @coveralls @cdce8p @Pierre-Sassoulas