-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require \
for asterisks in Sphinx-style parameter docstrings
#5464
Conversation
Pull Request Test Coverage Report for Build 1535712912
💛 - Coveralls |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was joking about regex, I like them fondly. But the approach with regex might have been an original design mistake. Good job managing with that though. The fix is quite dandy, Also the more tests we have the more manageable a migration from regex in the future will be if hard to fix bugs keep piling up. Chances are most case are handled and we won't have to change this too often.
I do to, but what is really annoying is how these patterns are written. It doesn't allow you to easily copy them over to regex101.com or a similar engine. That has really frustrated my process of working on these.. |
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
doc/whatsnew/<current release.rst>
.Type of Changes
Description
Closes #5406
This took way longer than it should have.. Never do regex on a Friday..